Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runInLinuxVM: remove hwclock -s invocation #359309

Merged
merged 1 commit into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. runInLinuxVM: remove hwclock -s invocation

    Commit 97ed6b4 broke the systemd-boot
    tests (among others) because of the `hwclock -s` invocation. This was
    broken for a while, but not noticed because we didn't have a `set -e`
    before.
    
    The error
    
        hwclock: select() to /dev/rtc0 to wait for clock tick timed out
    
    MAY be related to an open QEMU bug[1]: I can't reproduce the error on
    aarch64-linux and x86_64-linux with `partitionTableType = "legacy";`.
    Also, the issue disappears on x86_64-linux when adding `--directisa`.
    
    However, the invocation was added in f73ff05
    10 years ago which didn't give any reasoning or pointer to what KVM bug
    this may be. Given that this must have happened on an ancient version,
    we agreed on removing it altogether[2].
    
    [1] https://gitlab.com/qemu-project/qemu/-/issues/1762
    [2] NixOS#354535 (comment)
    Ma27 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6f3d8a7 View commit details
    Browse the repository at this point in the history