Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: remove left-over rtc_cmos rootModule #359416

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

wolfgangwalther
Copy link
Contributor

This is not needed anymore after
65a50ea.

As discussed in #359309 (comment).

@Ma27

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is not needed anymore after
65a50ea.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 26, 2024
@ElvishJerricco
Copy link
Contributor

Anything we can do to test this doesn't break anything?

@wolfgangwalther
Copy link
Contributor Author

I did the tests described in #359309 (comment) at the bottom.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also built the tests listed.

If there is a likely break in production, it'll come from changing nixos/modules/system/boot/kernel.nix, I bet. But we ought to jiggle these defaults from time to time just to see what falls out, as a matter of not ossifying things, and this is as well-thought-out a change as I think we can hope for.

@ElvishJerricco ElvishJerricco merged commit 357a340 into NixOS:master Nov 27, 2024
33 checks passed
@wolfgangwalther wolfgangwalther deleted the remove-rtc-cmos branch November 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants