-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpq: init at 17.2 #359659
base: staging
Are you sure you want to change the base?
libpq: init at 17.2 #359659
Conversation
d97ea3c
to
ca6dc81
Compare
ca6dc81
to
1eb5366
Compare
Since psqlodbc is an official upstream project, we should take ownership of it.
The latest version is not available from odbc/versions.old/.., thus move to fetchFromGitHub. No changelog found anywhere.
1eb5366
to
862bd30
Compare
10eca45
to
b666fc2
Compare
Resolves NixOS#61580
b666fc2
to
141856c
Compare
Also builds on pkgsStatic now and thus solves #191920, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-compiles from aarch64-darwin
-> aarch64-linux
/x86_64-linux
perfectly, compared to postgresql.lib
which is failing again.
I think this is a huge improvement for reasons mentioned in #61580 (comment). Both for sustainability by reducing the number of unnecessary rebuilds and reducing complexity when cross-compiling or statically linking.
This creates a separate libpq package as discussed in #61580 (comment).
This brings down the number of rebuilds after updating
postgresql
to about 1.2k darwin and 2.5k linux. Before, they were ~ around 5k, IIRC.Unfortunately, we are still not anywhere low enough to be able to merge
postgresql
updates directly into master. I think the nr. 1 reason for that ispostgresqlTestHook
- and the fact that many packages use a very simple postgresql server in their build dependencies for the check phase.The only way to get the number of rebuilds lower would be to package
postgresqlTestHook
as a separate postgresql derivation. The idea would be, that security related issues are irrelevant for the check phase of other packages - and thus updating this separately could easily go through staging with a certain delay. This derivation could also be one that is built with the minimal feature set, making it slimmer overall.I still think that introducing
libpq
is a good thing on it's own, thus this PR.Closes #61580 and #191920
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.