Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpq: init at 17.2 #359659

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Nov 27, 2024

This creates a separate libpq package as discussed in #61580 (comment).

This brings down the number of rebuilds after updating postgresql to about 1.2k darwin and 2.5k linux. Before, they were ~ around 5k, IIRC.

Unfortunately, we are still not anywhere low enough to be able to merge postgresql updates directly into master. I think the nr. 1 reason for that is postgresqlTestHook - and the fact that many packages use a very simple postgresql server in their build dependencies for the check phase.

The only way to get the number of rebuilds lower would be to package postgresqlTestHook as a separate postgresql derivation. The idea would be, that security related issues are irrelevant for the check phase of other packages - and thus updating this separately could easily go through staging with a certain delay. This derivation could also be one that is built with the minimal feature set, making it slimmer overall.

I still think that introducing libpq is a good thing on it's own, thus this PR.

Closes #61580 and #191920

Things done

  • Built on platform(s)
    • x86_64-linux (the directly changed packages)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Since psqlodbc is an official upstream project, we should take ownership
of it.
The latest version is not available from odbc/versions.old/.., thus move
to fetchFromGitHub.

No changelog found anywhere.
@wolfgangwalther wolfgangwalther removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2024
@wolfgangwalther wolfgangwalther force-pushed the postgresql-libpq branch 2 times, most recently from 10eca45 to b666fc2 Compare November 28, 2024 19:03
@wolfgangwalther
Copy link
Contributor Author

Also builds on pkgsStatic now and thus solves #191920, too.

Copy link
Member

@szlend szlend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-compiles from aarch64-darwin -> aarch64-linux/x86_64-linux perfectly, compared to postgresql.lib which is failing again.

I think this is a huge improvement for reasons mentioned in #61580 (comment). Both for sustainability by reducing the number of unnecessary rebuilds and reducing complexity when cross-compiling or statically linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants