Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsautocomplete: 0.73.2 -> 0.75.0 #360986

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

kalekseev
Copy link
Contributor

@kalekseev kalekseev commented Dec 2, 2024

Things done

dropped support for dotnet 6, 7 #326335

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MikaelFangel
Copy link
Contributor

MikaelFangel commented Dec 2, 2024

Fixes #340194 and supersedes #341231

@gepbird gepbird requested review from mdarocha and gbtb December 3, 2024 08:28
@kirillrdy
Copy link
Member

kirillrdy commented Dec 3, 2024

@ofborg build fsautocomplete

@MikaelFangel
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360986


aarch64-darwin

✅ 1 package built:
  • fsautocomplete

Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes LGTM, tested the binary on x86_64-linux.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 360986


x86_64-linux

✅ 1 package built:
  • fsautocomplete

@gepbird gepbird added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 5, 2024
@gepbird gepbird added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@kirillrdy kirillrdy merged commit e19e156 into NixOS:master Dec 5, 2024
50 of 52 checks passed
@corngood corngood added the backport release-24.11 Backport PR automatically label Dec 12, 2024
@nix-backports
Copy link

nix-backports bot commented Dec 12, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants