-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsautocomplete: 0.73.2 -> 0.75.0 #360986
Merged
Merged
fsautocomplete: 0.73.2 -> 0.75.0 #360986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ofborg build fsautocomplete |
|
gepbird
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes LGTM, tested the binary on x86_64-linux.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 360986
x86_64-linux
✅ 1 package built:
- fsautocomplete
gepbird
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Dec 5, 2024
MikaelFangel
approved these changes
Dec 5, 2024
gepbird
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Dec 5, 2024
This was referenced Dec 5, 2024
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 2
This PR was reviewed and approved by two reputable people
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
dropped support for dotnet 6, 7 #326335
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.