python312Packages.wheel: 0.44.0 -> 0.45.1, fix poetry2nix #361930
Merged
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the beginning/mid of September, some python packages like PyYAML fail to build with poetry2nix using nixpkgs master and release-24.11. The issue we're encountering is pypa/setuptools#4683. I believe the root cause is the update of setuptools to 75.1.1 in 6b98b10.
We are encountering this for instance in the authentik-nix flake. The issue can be reliably fixed by bumping wheel to 0.45.0 but the override is a bit ugly, see fpletz/authentik-nix@24907f6.
This issue is solely related to poetry2nix builds and not for python packages in nixpkgs itself. I haven't investigated deeply what poetry2nix is doing differently under the hood than the python packaging in nixpkgs. Maybe some of our python maintainers can enlighten me here. Since it's a poetry2nix issue, I would prefer a fix in poetry2nix itself but it's abandonware yet still used by lots of people until the pyproject-nix tooling is ready for primetime. Putting the wheel package bump into poetry2nix is IMHO also not an ideal solution. A fix in nixpkgs (this PR) would also fix the issue but needs to be backported to 24.11 and is a mass-rebuild.
The fix for setuptools in pypa/setuptools#4684 was released with 75.2.0. The fix for wheel in pypa/wheel#638 was released in 0.45.0. I'm not entirely sure which of the two packages we should bump but I've chosen wheel for this PR.
Further ideas or solutions to fix the situation are appreciated.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.