Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] dotnet: nixfmt output of nuget-to-nix #362190

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[Backport release-24.11] dotnet: nixfmt output of nuget-to-nix #362190

merged 3 commits into from
Dec 5, 2024

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Dec 5, 2024 •
edited by corngood
Loading

Bot-based backport to release-24.11, triggered by a label in #361579.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@corngood @github-actions
dotnet: nixfmt output of nuget-to-nix
d309782 
(cherry picked from commit 597474a)
@corngood @github-actions
dotnet: use fallback target packages from current binary sdk
c196cdb 
This was using the bootstrap SDK, which doesn't match the version of the
source-built SDK.  This will still be a problem if the binary and
source-built SDKs don't have the same version.

(cherry picked from commit d343c85)
@corngood @github-actions
Revert "scarab: remove nuget patch"
b7e3f1f 
This reverts commit 7cd9f93.

(cherry picked from commit 8fb55a6)
@nix-backports nix-backports bot mentioned this pull request Dec 5, 2024
Merged
13 tasks
@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Dec 5, 2024
@nix-owners nix-owners bot requested a review from corngood December 5, 2024 20:16
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 5, 2024
@corngood
Copy link
Contributor

corngood commented Dec 5, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362190

x86_64-linux

✅ 1 package built:
  • scarab

@corngood corngood merged commit a7f5757 into release-24.11 Dec 5, 2024
21 of 22 checks passed
@corngood corngood deleted the backport-361579-to-release-24.11 branch December 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood Awaiting requested review from corngood

Assignees
No one assigned
Labels
6.topic: dotnet Language: .NET 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@corngood