Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scarab: 2.5.0.0 -> 2.6.0.0 #362727

Merged
merged 1 commit into from
Dec 8, 2024
Merged

scarab: 2.5.0.0 -> 2.6.0.0 #362727

merged 1 commit into from
Dec 8, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Dec 7, 2024

Release: https://github.com/fifty-six/Scarab/releases/tag/v2.6.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/), only tested whether the GUI opens
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 7, 2024
@gepbird
Copy link
Contributor Author

gepbird commented Dec 7, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362727


x86_64-linux

✅ 1 package built:
  • scarab

@huantianad
Copy link
Contributor

I saw deps.nix got formatted, did they change the output format of the script, or was it intentionally formatted?

@gepbird
Copy link
Contributor Author

gepbird commented Dec 7, 2024

I saw deps.nix got formatted, did they change the output format of the script, or was it intentionally formatted?

Yes, they did change it temporarily to make the GitHub check green: #361579

Copy link
Contributor

@huantianad huantianad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that my mods still work.


nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362727


x86_64-linux

✅ 1 package built:
  • scarab

@SigmaSquadron SigmaSquadron added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 7, 2024
@ofborg ofborg bot requested review from huantianad and SigmaSquadron December 8, 2024 01:19
@Aleksanaa Aleksanaa merged commit ff98842 into NixOS:master Dec 8, 2024
63 of 64 checks passed
@gepbird gepbird deleted the scarab-2.6.0.0 branch December 8, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants