tone: 0.1.5 -> 0.2.3 #364325

jwillikers · 2024-12-11T19:24:07Z

Clean up the recipe, including a version check and update script.

Things done

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/to/tone/package.nix

pkgs/by-name/to/tone/update.sh

gepbird

Changes LGTM and tested the binary. Looking at the releases this seems safe to backport.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364325

`x86_64-linux`

✅ 1 package built:

tone

jwillikers · 2024-12-14T15:00:11Z

Updated to 0.2.3

gepbird

Thanks for opening the issue and updating the package, upstream resolved it really fast!

gepbird · 2024-12-14T23:49:22Z

pkgs/by-name/to/tone/package.nix

    rev = "v${version}";
-    sha256 = "sha256-HhXyOPoDtraT7ef0kpE7SCQbvGFLrTddzS6Kdu0LxW4=";
+    hash = "sha256-fe0fcX617vsRdu42FEan181Zh5Todt9FLtOuD+C7yqA=";


I got a hash mismatch

Most likely upstream deleted and made a new 0.2.3 release sandreas/tone#77 (comment)

error: hash mismatch in fixed-output derivation '/nix/store/9y5bgmn5il6fpwkgzhwi8sld7i6fpvi9-source.drv': likely URL: https://github.com/sandreas/tone/archive/v0.2.3.tar.gz specified: sha256-fe0fcX617vsRdu42FEan181Zh5Todt9FLtOuD+C7yqA= got: sha256-NBFAPEeUKZgyfNlvcOBS1IpktEnI+fOd9WLj0ByzpLY=

Yeah, I think that's what happened. Should be good now.

gepbird · 2024-12-14T23:52:56Z

pkgs/by-name/to/tone/package.nix


  dotnetInstallFlags = [
    "-p:PublishSingleFile=false"
  ];

-  dotnet-sdk = dotnetCorePackages.sdk_6_0;


Even though currently .NET 8 is the default sdk, I think we should be explicit and keep dotnet-sdk and dotnet-runtime attrs (we can drop the extra dotnet flag that forces a TargetFramework). It could be useful for example when .NET 8 will become EOL and .NET 10 will be the default: instead of automatically upgrading to incompatible 10, this package would still work but will be marked insecure.

Great to know! I'll keep that in mind for C# packages from now on.

gepbird · 2024-12-14T23:56:16Z

pkgs/by-name/to/tone/package.nix

+    platforms = with lib.platforms; linux ++ darwin ++ windows;
+    broken = !stdenv.hostPlatform.isLinux;


Interesting pattern, and make sense since upstream supports these platforms and we only tested the linux build, but I haven't seen packages being marked as broken without someone observing the failure.

Nit:

Suggested change

platforms = with lib.platforms; linux ++ darwin ++ windows;

broken = !stdenv.hostPlatform.isLinux;

platforms = with lib.platforms; linux ++ darwin ++ windows;

broken = !stdenvNoCC.isLinux;

Done. I think that platforms is supposed to represent all the platforms a package supports. I don't really have a good way test on a mac, and I don't even want to think about trying to run Nix on Windows, which is why I did it this way. I was recommended this approach when submitting either the wlink or wchisp package, since Linux was all I'd confirmed as working.

I just tested this on both darwin archs, and it works at least enough to do --help and --version.

I think we should remove broken and let it be added if/when actual problems are discovered.

Thank you for testing, I've updated this as suggested.

gepbird · 2024-12-14T23:57:38Z

pkgs/by-name/to/tone/package.nix


  src = fetchFromGitHub {
    owner = "sandreas";
-    repo = pname;
+    repo = "tone";
    rev = "v${version}";


Nit

Suggested change

rev = "v${version}";

rev = "refs/tags/v${version}";

gepbird

Thanks, LGTM!

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364325

`x86_64-linux`

✅ 1 package built:

tone

Aleksanaa · 2024-12-15T13:41:35Z

@ofborg build tone

nix-backports · 2024-12-17T18:25:12Z

Successfully created backport PR for release-24.11:

[Backport release-24.11] tone: 0.1.5 -> 0.2.3 #365959

tone: format

4700e0a

jwillikers requested review from jvanbruegge, mdarocha and natsukium and removed request for jvanbruegge and mdarocha December 11, 2024 19:25

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 11, 2024

ofborg bot added the 10.rebuild-linux: 1 label Dec 12, 2024

gepbird suggested changes Dec 13, 2024

View reviewed changes

pkgs/by-name/to/tone/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/to/tone/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/to/tone/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/to/tone/update.sh Outdated Show resolved Hide resolved

jwillikers mentioned this pull request Dec 13, 2024

Update to supported .NET version sandreas/tone#77

Closed

jwillikers added 4 commits December 13, 2024 14:50

tone: clean up

b4bd73c

tone: use versionCheckHook

dbffcef

tone: use update script

818d1c6

tone: add changelog

4d0505c

jwillikers force-pushed the tone-2.0.1 branch from f4acc6b to d5cb945 Compare December 13, 2024 20:56

jwillikers changed the title ~~tone: 0.1.5 -> 0.2.1~~ tone: 0.1.5 -> 0.2.2 Dec 13, 2024

github-actions bot removed the 10.rebuild-linux: 1 label Dec 13, 2024

gepbird mentioned this pull request Dec 13, 2024

.NET 6/7 are EOL #326335

Open

17 tasks

gepbird approved these changes Dec 13, 2024

View reviewed changes

gepbird added the backport release-24.11 Backport PR automatically label Dec 13, 2024

gepbird requested a review from corngood December 13, 2024 22:03

ofborg bot added the 10.rebuild-linux: 1 label Dec 14, 2024

jwillikers force-pushed the tone-2.0.1 branch from 56d29bb to cb36052 Compare December 14, 2024 14:59

jwillikers changed the title ~~tone: 0.1.5 -> 0.2.2~~ tone: 0.1.5 -> 0.2.3 Dec 14, 2024

github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 labels Dec 14, 2024

gepbird suggested changes Dec 14, 2024

View reviewed changes

jwillikers force-pushed the tone-2.0.1 branch 2 times, most recently from 6ba9006 to 51e8b9f Compare December 15, 2024 01:41

tone: 0.1.5 -> 0.2.3

2f9f802

jwillikers force-pushed the tone-2.0.1 branch 2 times, most recently from 8fa03fe to 8e0867f Compare December 15, 2024 01:45

jwillikers requested a review from gepbird December 15, 2024 03:35

gepbird approved these changes Dec 15, 2024

View reviewed changes

gepbird added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 15, 2024

jwillikers added 2 commits December 16, 2024 09:01

tone: update meta.platforms to be correct

64ec0ab

tone: add myself as maintainer

152ca05

jwillikers force-pushed the tone-2.0.1 branch from 8e0867f to 152ca05 Compare December 16, 2024 15:01

github-actions bot removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 16, 2024

corngood approved these changes Dec 16, 2024

View reviewed changes

wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 16, 2024

ofborg bot added 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 17, 2024

corngood merged commit 2c61f5d into NixOS:master Dec 17, 2024
43 of 44 checks passed

nix-backports bot mentioned this pull request Dec 17, 2024

[Backport release-24.11] tone: 0.1.5 -> 0.2.3 #365959

Merged

1 task

jwillikers deleted the tone-2.0.1 branch December 17, 2024 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tone: 0.1.5 -> 0.2.3 #364325

tone: 0.1.5 -> 0.2.3 #364325

jwillikers commented Dec 11, 2024

gepbird left a comment

jwillikers commented Dec 14, 2024

gepbird left a comment

gepbird Dec 14, 2024 •

edited

Loading

jwillikers Dec 15, 2024

gepbird Dec 14, 2024 •

edited

Loading

jwillikers Dec 15, 2024

jwillikers Dec 15, 2024

gepbird Dec 14, 2024 •

edited

Loading

jwillikers Dec 15, 2024

corngood Dec 16, 2024

jwillikers Dec 16, 2024

gepbird Dec 14, 2024

jwillikers Dec 15, 2024

gepbird left a comment

Aleksanaa commented Dec 15, 2024

nix-backports bot commented Dec 17, 2024

		platforms = with lib.platforms; linux ++ darwin ++ windows;
		broken = !stdenv.hostPlatform.isLinux;

tone: 0.1.5 -> 0.2.3 #364325

tone: 0.1.5 -> 0.2.3 #364325

Conversation

jwillikers commented Dec 11, 2024

Things done

gepbird left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

jwillikers commented Dec 14, 2024

gepbird left a comment

Choose a reason for hiding this comment

gepbird Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gepbird Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gepbird Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gepbird left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Aleksanaa commented Dec 15, 2024

nix-backports bot commented Dec 17, 2024

`nixpkgs-review` result

`x86_64-linux`

gepbird Dec 14, 2024 •

edited

Loading

gepbird Dec 14, 2024 •

edited

Loading

gepbird Dec 14, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`