{alttpr-opentracker,am2rlauncher,avalonia-ilspy,clr-loader,dafny,formula,gh-gei,ilspycmd,inklecate,knossosnet}: update from .NET 6/7 to .NET 8 #366067
+1,686
−1,084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gepbird
suggested changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks a lot for migrating most of the remaining packages using an EOL .NET and reporting these to upstreams!
Most of the main dotnet related changes look good, and since you did some refactors like moving to finalAttrs, removing with lib;, etc., I left some nits some about general refactor changes. Feel free to ignore if it's too out of scope.
ofborg
bot
added
the
2.status: merge conflict
GGG-KILLER
force-pushed
the
dotnet-upgrades
branch
from
7b36d1a to
894e78e
Compare
GGG-KILLER
removed
the
2.status: merge conflict
|
gepbird
approved these changes
Dec 19, 2024
ofborg
bot
requested review from
emilytrau,
AngryAnt,
mdarocha,
shrimpram,
siraben,
layus,
peeley and
lafrenierejm
wegank
added
the
12.approvals: 1
cdombroski
approved these changes
Dec 20, 2024
wegank
added
12.approved-by: package-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches the following packages to point to .NET 8.0:
alttpr-opentracker(issue upstream: .NET 7 has hit EOL trippsc2/OpenTracker#93)am2rlauncher(issue upstream: .NET 6 has hit EOL AM2R-Community-Developers/AM2RLauncher#93)avalonia-ilspy: (issue upstream: .NET 6 has hit EOL icsharpcode/AvaloniaILSpy#151)clr-loader(no issue upstream because they're just sample projects and not actually built)dafny(issue upstream: Support dotnet 8 dafny-lang/dafny#4948)formula(issue upstream: .NET 6 has hit EOL VUISIS/formula-dotnet#42)inklecate(issue upstream: .NET 6 has hit EOL inkle/ink#922)knossosnet(issue upstream: .NET 6 has hit EOL KnossosNET/Knossos.NET#259)The following have been upgraded to a new version that has support for a newer .NET:
gh-gei(first version with .NET 8 support is v1.10.1, but might as well upgrade to latest while I'm at it):ilspycmd(upgrade to preview version was needed because it's the only one that has .NET 8 support):Part of #326335.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.