python3Packages.yowsup: 2.5.2 -> 2.5.7

[Ma27]

Motivation for this change

The latest update of yowsup (https://github.com/tgalal/yowsup/releases/tag/v2.5.7)
contains the following fixes:

• Updated tokens
• Fixed TypeError: 'RemoveGroupsNotificationProtocolEntity' object has no attribute '__getitem__' tgalal/yowsup#1842: Bug in protocol_groups RemoveGroupsNotificationProtocolEntity
• Other minor bug fixes

The argparse-dependency.patch required a rebase onto the latest
version of setup.py and ensures that argparse won't be needed as
extra dependency as our python3 package ships argparse by default.

A short note to Python 2 support:

the actual issue related to Python 2.x support has been resolved
(tgalal/yowsup#2325 (comment)),
however this relies on six==1.10 which isn't support by nixpkgs as
six has been bumped to 1.11. When trying to inject a patched version
of our six package based on six==1.10 you'll run into issues with
duplicated libraries in your closure as further build dependencies
(pytest in this case) use the latest six version. As Python 2.7 will
die in 2020 (https://pythonclock.org/) and patching around in the
dependencies of pytest to get yowsup running isn't worth the effort
in my opinion I decided to keep the Python 2.x build disabled for now.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[dotlambda]

drop this line

[dotlambda]

Even if yowsup pins six==1.10 it might work just fine with 1.11. Did you try simply dropping the version pinning?

[Ma27]

the following comment contains several resources that explain the issue: tgalal/yowsup#2416 (comment)

Unfortunately the combination of six==1.11 and Python 2.7 breaks the test suite and the binary.
Unless we use six==1.10 for this package (which might require a certain amount of effort as explained in the commit message) I think that the easiest solution might be to keep Python 2.7 disabled for now.

[dotlambda]

Could you please update this message so it mentions the six==1.11 incompatibility?

[Ma27]

@dotlambda done :-)

[Ma27]

ping @dotlambda

[dotlambda]

@GrahamcOfBorg build python2.pkgs.yowsup python3.pkgs.yowsup

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: python3.pkgs.yowsup

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.yowsup

Partial log (click to expand)

.                                                                        [ 95%]
yowsup/layers/protocol_profiles/protocolentities/test_iq_status_set.py . [ 95%]
.                                                                        [ 96%]
yowsup/layers/protocol_profiles/protocolentities/test_iq_unregister.py . [ 97%]
.                                                                        [ 98%]
yowsup/layers/protocol_receipts/protocolentities/test_receipt_incoming.py . [ 99%]
                                                                         [ 99%]
yowsup/layers/protocol_receipts/protocolentities/test_receipt_outgoing.py . [100%]

========================== 124 passed in 1.06 seconds ==========================

[GrahamcOfBorg]

Success on aarch64-linux (full log)

Attempted: python3.pkgs.yowsup

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.yowsup

Partial log (click to expand)

yowsup/layers/protocol_profiles/protocolentities/test_iq_status_set.py . [ 95%]
.                                                                        [ 96%]
yowsup/layers/protocol_profiles/protocolentities/test_iq_unregister.py . [ 97%]
.                                                                        [ 98%]
yowsup/layers/protocol_receipts/protocolentities/test_receipt_incoming.py . [ 99%]
                                                                         [ 99%]
yowsup/layers/protocol_receipts/protocolentities/test_receipt_outgoing.py . [100%]

========================== 124 passed in 4.91 seconds ==========================
/nix/store/vlikb0pakx9g7r8gm7fjqal77l7w66kp-python3.6-yowsup-2.5.7