Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes app listing offset #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rscmendes
Copy link

This PR is based in PR #62, which in turn is based on this comment.

This PR fixes the offset field when listing the apps.
It also adds a test to check that the offset is working properly.

@smfahadhassan
Copy link

This code works as long as the offset is below 3500, but for greater (or equal) values it throws an "String index out of range" Error ..

Traceback (most recent call last):
File "test.py", line 129, in
appList = server.list(cat, catList[0], 100, 3500)
File "/mnt/c/Users/virde/Desktop/gpapi/venv/lib/python3.8/site-packages/gpapi/googleplay.py", line 469, in list
path += "&ctntkn=" + self.get_token(int(offset))
File "/mnt/c/Users/virde/Desktop/gpapi/venv/lib/python3.8/site-packages/gpapi/googleplay.py", line 444, in get_token
token = "C" + key + requests.utils.quote(code_suffix[s])
IndexError: string index out of range

Any help will be appreciated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants