Output graph files to target
directory and improve Graphviz output
#1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph files
.mmd
and.dot
files are not committed to the repository and hence writing them to the source directory (inside thegenerated
folder) does not provide any benefit and even has some drawbacks (eg. build errors when switching branches and test are no longer present). This PR changes the output directory to be inside thetarget
directory in thesolidity_cargo_tests
crate directory.These output files are opt-in via a
RENDER_GRAPHS
environment variable. The performance impact of their generation is not too big, but they are generally unnecessary unless we're debugging binding rules.There are also some tweaks and added information to the
.dot
file output to improve graph readability and make tracing nodes to rules easier.