Deprecate bgppeerv1beta1

v1beta2 is around for a while now, deprecating v1beta1 would allow us to (one day!) get rid of the conversion webhooks. Signed-off-by: Federico Paolinelli <[email protected]>
Nordix · Aug 29, 2024 · 8823067 · 8823067
1 parent cbb36c7
commit 8823067
Show file tree

Hide file tree

Showing 10 changed files with 21 additions and 0 deletions.
diff --git a/api/v1beta1/bgppeer_types.go b/api/v1beta1/bgppeer_types.go
@@ -100,6 +100,7 @@ type BGPPeerStatus struct {
 //+kubebuilder:printcolumn:name="ASN",type=string,JSONPath=`.spec.peerASN`
 //+kubebuilder:printcolumn:name="BFD Profile",type=string,JSONPath=`.spec.bfdProfile`
 //+kubebuilder:printcolumn:name="Multi Hops",type=string,JSONPath=`.spec.ebgpMultiHop`
+//+kubebuilder:deprecatedversion:warning="v1beta1 is deprecated, please use v1beta2"
 
 // BGPPeer is the Schema for the peers API.
 type BGPPeer struct {

diff --git a/charts/metallb/charts/crds/templates/crds.yaml b/charts/metallb/charts/crds/templates/crds.yaml
@@ -365,6 +365,8 @@ spec:
         - jsonPath: .spec.ebgpMultiHop
           name: Multi Hops
           type: string
+      deprecated: true
+      deprecationWarning: v1beta1 is deprecated, please use v1beta2
       name: v1beta1
       schema:
         openAPIV3Schema:

diff --git a/config/crd/bases/metallb.io_bgppeers.yaml b/config/crd/bases/metallb.io_bgppeers.yaml
@@ -27,6 +27,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-frr-k8s-prometheus.yaml b/config/manifests/metallb-frr-k8s-prometheus.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-frr-k8s.yaml b/config/manifests/metallb-frr-k8s.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-frr-prometheus.yaml b/config/manifests/metallb-frr-prometheus.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-frr.yaml b/config/manifests/metallb-frr.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-native-prometheus.yaml b/config/manifests/metallb-native-prometheus.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/config/manifests/metallb-native.yaml b/config/manifests/metallb-native.yaml
@@ -385,6 +385,8 @@ spec:
     - jsonPath: .spec.ebgpMultiHop
       name: Multi Hops
       type: string
+    deprecated: true
+    deprecationWarning: v1beta1 is deprecated, please use v1beta2
     name: v1beta1
     schema:
       openAPIV3Schema:

diff --git a/website/content/configuration/_index.md b/website/content/configuration/_index.md
@@ -119,6 +119,10 @@ or more external BGP routers.
 In order to do so, an instance of `BGPPeer` must be created for each
 router we want metallb to connect to.
 
+{{% notice note %}}
+The BGPPeer v1beta1 version is deprecated. Please consider using v1beta2.
+{{% /notice %}}
+
 For a basic configuration featuring one BGP router and one IP address
 range, you need 4 pieces of information: