Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24986: Enable scala 3 cross compilation #5727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 14, 2024

https://issues.rudder.io/issues/24986

Merge back commits from #5701.

The main changes are:

  • switching to scala 2.13.14 to have the new target,
  • using -Xsource:3-cross as source argument for scalac in place of -Xsource:3

The only one missing are:

The commits with "fixme" were reviewed like that:

  • xml pattern matching: the change was mostly ok, change some selectors
  • disable specs2 tests: tests were rewritten in zio-tests

Now, we need to check that everything still works in plugins

@fanf fanf requested a review from clarktsiory June 14, 2024 13:10
@fanf fanf force-pushed the arch_24986/enable_scala_3_cross_compilation branch from a855029 to 423fd93 Compare June 14, 2024 13:12
@VinceMacBuche
Copy link
Member

needs rebase, but lgtm

Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, it runs fine. As already reported, it needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants