Testing day 1 #6013
Open
Testing day 1 #6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout sharing any state
This ensures that it's closed to modification, that way testing this class is enough to test its features, you don't need to test features in subclasses anymore.
…because you don't want a caller to add files without modId management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not about ZIO Test but uses ZIO Test to change easily lifetime of services following refactorings.
The ultimate goal is to have test case code as short as possible because it's what matter for the reader.
To achieve that goal there are a list of transformations required:
Please comment individual steps in case you disagree on specific transformations. Of course you can always write a general comment if you want.