-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector components (costs, scores etc.) as classes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common pattern for initialisers.
…ction to scores.mean
Leave it to the numba compiler for now. Checking it in a good way is complicated due to the generic classes such as CostBasedChangeScore
Decoupled from numba and the detectors as opposed to other suggested designs.
Naming decision:
|
This was referenced Nov 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Unify the detector components. Make them safer. Make the extension pattern simpler and clearer.
See #23 for discussions.
New features:
The
BaseIntervalScorer
class, inheriting from sktime.BaseEstimator. Public methods:fit(self, X, y=None) -> self
evaluate(self, cuts: ArrayLike) -> np.ndarray
Four sub base classes inheriting from BaseIntervalScorer:
skchange.costs.BaseCost
. Expects 2 columns in cuts: start, end.skchange.change_scores.BaseChangeScore
. Expects 3 columns in cuts: start, split, end.skchange.anomaly_scores.BaseSaving
. Expects 2 columns in cuts: start, end.skchange.anomaly_scores.BaseLocalAnomalyScore
: Expects 4 columns in cuts: outer_start, inner_start, inner_end, outer_end.Classes for automatically converting costs to any of the three other score classes.
Convenience functions allowing either costs or an appropriate score to be used as input to all the detectors.
All existing functionality is implemented within the new design + additions.