FailOnGitError added #1104
FailOnGitError added #1104
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…otNet#1113) * Add nuget restore CLI PackagesDirectory for package.config * Add required option when restoring via package.config * Add unit tests to ensure we include the CLI option * Fix unit tests to allow for multiple operating systems * Ensure that non windows OS's execute unit tests. * Fix repository filter unit tests * Remove tokens from source code (security) * Adjust OctokitClient to enable anonymous authentication if no token is supplied. * Add xml comments to the AuthSettings model * Help Nukeeper engineering's identify potentially duplicated code. * Assist with security token refactoring. * Fix the Nuget Restore tests * Ensure that unit tests have mono.CanRun set to true.
|
@MartinDemberger can you please rebase the branch on the latest master? Ty! |
Fix yaml code blocks
…tNet#1107) Co-authored-by: Ari Kalish <[email protected]>
… of everyone in the Project (NuKeeperDotNet#1108) Co-authored-by: Ari Kalish <[email protected]>
* 📦 Automatic update of NuGet.CommandLine to 5.11.0 * Bump packaging script to match nuget.commandline version
@msallin @i did the rebase but am unsure if it's done correct. There are changes in the changeset which I don't know. You can give me a short hint if I have done an error. Then I will redo the changes on a clean branch. |
|
Doesn't look correct to me. I looked at your fork, to see if I can advise. The problem is that you did some merges and additionally, the commit on which this branch is based, is behind the master. If you don't mind, I suggest that you reapply the changes on a clean branch.
|
|
I created #1140 with the cleaned changes. |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
A new option is added. When the option FailOnGitError is set the run failes when the call to get the available versions failes.
This is only the first part of a fix for #930
On most of git calls the error is ignored and NuKeeper notifies success.
🆕 What is the new behavior (if this is a feature change)?
A new option
--failongiterroris introduced and when this option is set an error in a git call results in an error of NuKeeper.In the current process the option is only used when searching for the available package versions.
💥 Does this PR introduce a breaking change?
No, the default behaviour is unchanged.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting