-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.1.1 #8
Changes from all commits
713717f
82f1073
8a056ec
5e20e1b
81050f1
014f1c9
0657d35
f21f1c5
f4eb94b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.3.6 | ||
2.6.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module ClaimToken | ||
VERSION = "0.1.0" | ||
VERSION = "0.1.1".freeze | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we actually need to specify freeze now ? I though this was being automatically done by ruby ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to this stack overflow discussion you should do this or add the frozen string literal magic comment until Ruby 3, in which it'd do this by default https://stackoverflow.com/a/37799399 |
||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,16 +8,16 @@ | |
|
||
def stub_random_iv | ||
before do | ||
cipher = OpenSSL::Cipher::Cipher.new(ClaimToken.configuration.cipher_type) | ||
cipher = OpenSSL::Cipher.new(ClaimToken.configuration.cipher_type) | ||
allow(cipher).to receive(:random_iv).and_return("\nK\x0F^1X\xE6\x8A'\xDBf\xB8\x93i\xA3\x9D") | ||
allow(OpenSSL::Cipher::Cipher).to receive(:new).and_return(cipher) | ||
allow(OpenSSL::Cipher).to receive(:new).and_return(cipher) | ||
end | ||
end | ||
|
||
def use_test_configuration | ||
before do | ||
ClaimToken.configure do |config| | ||
config.shared_encryption_key = "uFeb25D_z0BAGhgH7WKy8QBSat6kxfDa6PrKw1ox69U=" | ||
config.shared_encryption_key = "fba0d989f259ad36ada12c127356d420" | ||
config.digest_secret = "d22b90c9172649eaf49cd185f73bd4a53ec3ff4dc6f7d51f9dbaac62421e6dd297b38efcd431a7f2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This key is still 64 bits long, no potential issue there ? |
||
end | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aww this lil library still getting love 😁