Implement our own EventUtil.ContinueOnAddOnLoaded to avoid some rare …

…errors

SharedUtil.lua

@@ -31,6 +31,7 @@ do
 end
 
 Util.configIDLookup = {};
+Util.addonLoadedRegistry = {};
 
 function Util:DebugPrint(...)
     if not self.debug then return; end
@@ -76,6 +77,12 @@ function Util:OnInitialize()
                 eventFrame:UnregisterEvent('ADDON_LOADED');
                 self:RunOnLoadCallbacks();
             end
+            if self.addonLoadedRegistry[addonName] then
+                for _, callback in ipairs(self.addonLoadedRegistry[addonName]) do
+                    securecallfunction(callback);
+                end
+                self.addonLoadedRegistry[addonName] = nil;
+            end
         end
         if event == 'TRAIT_CONFIG_LIST_UPDATED' then
             self:RefreshConfigIDLookup();
@@ -107,6 +114,16 @@ function Util:GetterSetterIncrementFactory(db, postSetCallback)
     return getter, setter, increment;
 end
 
+function Util:ContinueOnAddonLoaded(addonName, callback)
+    if C_AddOns.IsAddOnLoaded(addonName) then
+        callback();
+        return;
+    end
+
+    self.addonLoadedRegistry[addonName] = self.addonLoadedRegistry[addonName] or {};
+    table.insert(self.addonLoadedRegistry[addonName], callback);
+end
+
 function Util:ResetRegistry()
     self.classTalentUILoadCallbacks = {
         minPriority = 1,

modules/changeBackground.lua

@@ -13,7 +13,7 @@ function Module:OnEnable()
     Util:OnTalentUILoad(function()
         self:SetupDefaultUI();
     end);
-    EventUtil.ContinueOnAddOnLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
+    Util:ContinueOnAddonLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
         self:SetupTTVUI();
     end);
 end

modules/copyTalentButtonInfo.lua

@@ -21,14 +21,14 @@ function Module:OnEnable()
     Util:OnTalentUILoad(function()
         self:SetupHook(Util:GetTalentFrame());
     end);
-    EventUtil.ContinueOnAddOnLoaded('Blizzard_GenericTraitUI', function()
+    Util:ContinueOnAddonLoaded('Blizzard_GenericTraitUI', function()
         self:SetupHook(GenericTraitFrame);
     end);
-    EventUtil.ContinueOnAddOnLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
+    Util:ContinueOnAddonLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
         local talentsTab = TalentViewer and TalentViewer.GetTalentFrame and TalentViewer:GetTalentFrame();
         if not talentsTab then return; end
         self:SetupHook(talentsTab);
-    end)
+    end);
     self:RegisterEvent('PLAYER_REGEN_DISABLED');
     self:RegisterEvent('PLAYER_REGEN_ENABLED');
     EventRegistry:RegisterCallback("TalentDisplay.TooltipCreated", self.OnTalentTooltipCreated, self)
@@ -127,7 +127,7 @@ function Module:OnSpellbookButtonEnter(button)
     if not spellID then return; end
     self.textToCopy = spellID;
     self:EnableBinding();
-    self:OnTalentTooltipCreated(nil, GameTooltip);
+    self:OnTalentTooltipCreated(nil, ElvUI_SpellBookTooltip or GameTooltip);
 end
 
 function Module:OnSpellbookButtonLeave()

modules/inspectDiff.lua

@@ -14,7 +14,7 @@ function Module:OnEnable()
     end);
 
     self.viewerButtonTextures = self.viewerButtonTextures or {};
-    EventUtil.ContinueOnAddOnLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
+    Util:ContinueOnAddonLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
         self:SetupViewerHook();
     end);
 end

modules/miniTreeInTooltip.lua

@@ -80,9 +80,9 @@ function Module:OnEnable()
     end)
     self:SecureHook(GameTooltip, "Show", "OnTooltipShow");
 
-    EventUtil.ContinueOnAddOnLoaded("Blizzard_InspectUI", function()
+    Util:ContinueOnAddonLoaded("Blizzard_InspectUI", function()
         self:HookInspectTalentsButton();
-    end)
+    end);
 end
 
 function Module:OnDisable()

modules/scaleTalentFrame.lua

@@ -16,9 +16,9 @@ function Module:OnEnable()
     Util:OnTalentUILoad(function()
         self:SetupHook(BLIZZARD_TALENT_UI);
     end);
-    EventUtil.ContinueOnAddOnLoaded(TALENT_TREE_VIEWER, function()
+    Util:ContinueOnAddonLoaded(TALENT_TREE_VIEWER, function()
         self:SetupHook(TALENT_TREE_VIEWER);
-    end)
+    end);
 end
 
 function Module:OnDisable()

modules/searchForIds.lua

@@ -17,9 +17,9 @@ function Module:OnEnable()
     Util:OnTalentUILoad(function()
         self:SetupHook(BLIZZARD_TALENT_UI);
     end);
-    EventUtil.ContinueOnAddOnLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
+    Util:ContinueOnAddonLoaded(TalentViewerLoader and TalentViewerLoader:GetLodAddonName() or 'TalentTreeViewer', function()
         self:SetupHook(TALENT_TREE_VIEWER);
-    end)
+    end);
 end
 
 function Module:OnDisable()