[OU-IMP] more review followups

openupgrade_scripts/scripts/account/17.0.1.2/post-migration.py

@@ -12,6 +12,100 @@
 ]
 
 
+COA_MAPPING = {
+    "l10n_ae.uae_chart_template_standard": "ae",
+    "l10n_ar.l10nar_base_chart_template": "ar_base",
+    "l10n_ar.l10nar_ex_chart_template": "ar_ex",
+    "l10n_ar.l10nar_ri_chart_template": "ar_ri",
+    "l10n_at.l10n_at_chart_template": "at",
+    "l10n_au.l10n_au_chart_template": "au",
+    "l10n_be.l10nbe_chart_template": "be_comp",
+    "l10n_bg.l10n_bg_chart_template": "bg",
+    "l10n_bo.bo_chart_template": "bo",
+    "l10n_br.l10n_br_account_chart_template": "br",
+    "l10n_ca.ca_en_chart_template_en": "ca_2023",
+    "l10n_ch.l10nch_chart_template": "ch",
+    "l10n_cl.cl_chart_template": "cl",
+    "l10n_cn.l10n_chart_china_small_business": "cn",
+    "l10n_co.l10n_co_chart_template_generic": "co",
+    "l10n_cr.account_chart_template_0": "cr",
+    "l10n_cz.cz_chart_template": "cz",
+    "l10n_de.l10n_de_chart_template": "de_skr03",
+    "l10n_de.l10n_chart_de_skr04": "de_skr04",
+    "l10n_de_skr03.l10n_de_chart_template": "de_skr03",
+    "l10n_de_skr04.l10n_chart_de_skr04": "de_skr04",
+    "l10n_dk.dk_chart_template": "dk",
+    "l10n_do.do_chart_template": "do",
+    "l10n_dz.l10n_dz_pcg_chart_template": "dz",
+    "l10n_ec.l10n_ec_ifrs": "ec",
+    "l10n_ee.l10nee_chart_template": "ee",
+    "l10n_eg.egypt_chart_template_standard": "eg",
+    "l10n_es.account_chart_template_assoc": "es_assec",
+    "l10n_es.account_chart_template_common": "es_common",
+    "l10n_es.account_chart_template_full": "es_full",
+    "l10n_es.account_chart_template_pymes": "es_pymes",
+    "l10n_et.l10n_et": "et",
+    "l10n_fi.fi_chart_template": "fi",
+    "l10n_fr.l10n_fr_pcg_chart_template": "fr",
+    "l10n_generic_coa.configurable_chart_template": "generic_coa",
+    "l10n_gr.l10n_gr_chart_template": "gr",
+    "l10n_gt.cuentas_plantilla": "gt",
+    "l10n_hk.l10n_hk_chart_template": "hk",
+    "l10n_hn.cuentas_plantilla": "hn",
+    "l10n_hr.l10n_hr_chart_template_rrif": "hr",
+    "l10n_hr.l10n_hr_euro_chart_template": "hr",
+    "l10n_hr_kuna.l10n_hr_kuna_chart_template_rrif": "hr_kuna",
+    "l10n_hu.hungarian_chart_template": "hu",
+    "l10n_id.l10n_id_chart": "id",
+    "l10n_ie.l10n_ie": "ie",
+    "l10n_il.il_chart_template": "il",
+    "l10n_in.indian_chart_template_standard": "in",
+    "l10n_it.l10n_it_chart_template_generic": "it",
+    "l10n_jp.l10n_jp1": "jp",
+    "l10n_jp.l10n_jp_chart_template": "jp",
+    "l10n_ke.l10nke_chart_template": "ke",
+    "l10n_kz.l10nkz_chart_template": "kz",
+    "l10n_lt.account_chart_template_lithuania": "lt",
+    "l10n_lu.lu_2011_chart_1": "lu",
+    "l10n_lv.chart_template_latvia": "lv",
+    "l10n_ma.l10n_ma_chart_template": "ma",
+    "l10n_mn.mn_chart_1": "mn",
+    "l10n_mx.mx_coa": "mx",
+    "l10n_my.l10n_my_chart_template": "my",
+    "l10n_mz.l10n_mz_chart_template": "mz",
+    "l10n_nl.l10nnl_chart_template": "nl",
+    "l10n_no.no_chart_template": "no",
+    "l10n_nz.l10n_nz_chart_template": "nz",
+    "l10n_pa.l10npa_chart_template": "pa",
+    "l10n_pe.pe_chart_template": "pe",
+    "l10n_ph.l10n_ph_chart_template": "ph",
+    "l10n_pk.l10n_pk_chart_template": "pk",
+    "l10n_pl.pl_chart_template": "pl",
+    "l10n_pt.pt_chart_template": "pt",
+    "l10n_ro.ro_chart_template": "ro",
+    "l10n_rs.l10n_rs_chart_template": "rs",
+    "l10n_sa.sa_chart_template_standard": "sa",
+    "l10n_se.l10nse_chart_template": "se",
+    "l10n_se.l10nse_chart_template_K2": "se_K2",
+    "l10n_se.l10nse_chart_template_K3": "se_K3",
+    "l10n_sg.sg_chart_template": "sg",
+    "l10n_si.gd_chart": "si",
+    "l10n_sk.sk_chart_template": "sk",
+    "l10n_syscohada.syscohada_chart_template": "syscohada",
+    "l10n_th.chart": "th",
+    "l10n_tr.chart_template_common": "tr",
+    "l10n_tr.l10n_tr_chart_template": "tr",
+    "l10n_tw.l10n_tw_chart_template": "tw",
+    "l10n_ua.l10n_ua_ias_chart_template": "ua_ias",
+    "l10n_ua.l10n_ua_psbo_chart_template": "ua_psbo",
+    "l10n_uk.l10n_uk": "uk",
+    "l10n_uy.uy_chart_template": "uy",
+    "l10n_ve.ve_chart_template_amd": "ve",
+    "l10n_vn.vn_template": "vn",
+    "l10n_za.default_chart_template": "za",
+}
+
+
 def _am_update_invoice_pdf_report_file(env):
     openupgrade.logged_query(
         env.cr,
@@ -395,6 +489,35 @@ def _force_install_account_payment_term_module_module(env):
         )
 
 
+def _map_chart_template_id_to_chart_template(
+    env, model_table, coa_m2o="chart_template_id", coa_name_column="chart_template"
+):
+    """
+    In tables that used to refer to a chart template in the database, set the new
+    column identitying the COA by the name of its localization module with the
+    `l10n_` prefix removed (usually the country's iso code)
+    """
+    env.cr.execute(
+        f"""SELECT m.id, CONCAT(imd.module, '.', imd.name)
+            FROM {model_table} m
+                JOIN ir_model_data imd
+                    ON imd.model='account.chart.template'
+                        AND m.{coa_m2o} = imd.res_id
+            WHERE m.{coa_m2o} IS NOT NULL
+            AND CONCAT(imd.module, '.', imd.name) IN %s
+        """,
+        (tuple(COA_MAPPING),),
+    )
+    chart_id2name = [(_id, COA_MAPPING[xmlid]) for _id, xmlid in env.cr.fetchall()]
+    openupgrade.map_values(
+        env.cr,
+        coa_m2o,
+        coa_name_column,
+        chart_id2name,
+        table=model_table,
+    )
+
+
 @openupgrade.migrate()
 def migrate(env, version):
     _account_payment_term_migration(env)
@@ -408,3 +531,5 @@ def migrate(env, version):
     _am_update_invoice_pdf_report_file(env)
     _onboarding_state_migration(env)
     _account_tax_group_migration(env)
+    _map_chart_template_id_to_chart_template(env, "res_company")
+    _map_chart_template_id_to_chart_template(env, "account_report")