[MIG] account_financial_report: Migration to 18.0

account_financial_report/README.rst

@@ -75,7 +75,7 @@ Example of configuration inferior limit:
 It means the first interval is from 0 to 15, the second from 16 to 30,
 and the third is 61+.
 
-Go on 'Invoicing' -> 'Reports' -> 'OCA accounting reports' -> 'Aged
+Go on 'Invoicing' -> 'Reporting' -> 'OCA accounting reports' -> 'Aged
 Partner Balance'
 
 When wizard is open, you need to select your interval configuration and
@@ -167,7 +167,7 @@ Contributors
    -  Pedro M. Baeza
    -  Sergio Teruel
    -  Ernesto Tejeda
-   -  Jo??o Marques
+   -  João Marques
    -  Alexandre D. D??az
    -  V??ctor Mart??nez
    -  Carolina Fernandez
@@ -180,10 +180,17 @@ Contributors
 -  Lois Rilo <[email protected]>
 -  Saran Lim. <[email protected]>
 -  Omar Casti??eira <[email protected]>
+-  Chau Le <[email protected]>
 
 Much of the work in this module was done at a sprint in Sorrento, Italy
 in April 2016.
 
+Other credits
+-------------
+
+The migration of this module from 17.0 to 18.0 was financially supported
+by Camptocamp.
+
 Maintainers
 -----------
 

account_financial_report/__manifest__.py

@@ -2,11 +2,11 @@
 # Author: Julien Coux
 # Copyright 2016 Camptocamp SA
 # Copyright 2020 ForgeFlow S.L. (https://www.forgeflow.com)
-# Copyright 2021 Tecnativa - Jo??o Marques
+# Copyright 2021 Tecnativa - João Marques
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Account Financial Reports",
-    "version": "17.0.1.5.0",
+    "version": "18.0.0.1.0",
     "category": "Reporting",
     "summary": "OCA Financial Reports",
     "author": "Camptocamp,"
@@ -47,6 +47,7 @@
     "assets": {
         "web.assets_backend": [
             "account_financial_report/static/src/js/*",
+            "account_financial_report/static/src/scss/*",
             "account_financial_report/static/src/xml/**/*",
         ],
     },

account_financial_report/models/account.py

@@ -1,4 +1,4 @@
-# ?? 2011 Guewen Baconnier (Camptocamp)
+# © 2011 Guewen Baconnier (Camptocamp)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).-
 from odoo import fields, models
 

account_financial_report/models/account_age_report_configuration.py

@@ -1,7 +1,7 @@
 # Copyright 2023 Ernesto García
 # Copyright 2023 Carolina Fernandez
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -21,7 +21,7 @@ class AccountAgeReportConfiguration(models.Model):
     def _check_line_ids(self):
         for rec in self:
             if not rec.line_ids:
-                raise ValidationError(_("Must complete Configuration Lines"))
+                raise ValidationError(self.env._("Must complete Configuration Lines"))
 
 
 class AccountAgeReportConfigurationLine(models.Model):
@@ -36,12 +36,14 @@ class AccountAgeReportConfigurationLine(models.Model):
     def _check_inferior_limit(self):
         for rec in self:
             if rec.inferior_limit <= 0:
-                raise ValidationError(_("Inferior Limit must be greather than zero"))
+                raise ValidationError(
+                    self.env._("Inferior Limit must be greather than zero")
+                )
 
     _sql_constraints = [
         (
             "unique_name_config_combination",
             "UNIQUE(name,account_age_report_config_id)",
-            _("Name must be unique per report configuration"),
+            "Name must be unique per report configuration",
         )
     ]

account_financial_report/models/account_group.py

@@ -1,4 +1,4 @@
-# ?? 2018 Forest and Biomass Romania SA
+# © 2018 Forest and Biomass Romania SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from odoo import api, fields, models

account_financial_report/readme/CONFIGURE.md

@@ -16,7 +16,7 @@ Example of configuration inferior limit:
 
 It means the first interval is from 0 to 15, the second from 16 to 30, and the third is 61+.
 
-Go on 'Invoicing' -> 'Reports' -> 'OCA accounting reports' -> 'Aged Partner Balance'
+Go on 'Invoicing' -> 'Reporting' -> 'OCA accounting reports' -> 'Aged Partner Balance'
 
 When wizard is open, you need to select your interval configuration and print report.
 

account_financial_report/readme/CONTRIBUTORS.md

@@ -20,7 +20,7 @@
   - Pedro M. Baeza
   - Sergio Teruel
   - Ernesto Tejeda
-  - Jo??o Marques
+  - João Marques
   - Alexandre D. D??az
   - V??ctor Mart??nez
   - Carolina Fernandez
@@ -30,6 +30,7 @@
 - Lois Rilo \<<[email protected]>\>
 - Saran Lim. \<<[email protected]>\>
 - Omar Casti??eira \<<[email protected]>\>
+- Chau Le \<<[email protected]>\>
 
 Much of the work in this module was done at a sprint in Sorrento, Italy
 in April 2016.

account_financial_report/readme/CREDITS.md

@@ -0,0 +1 @@
+The migration of this module from 17.0 to 18.0 was financially supported by Camptocamp.

account_financial_report/report/__init__.py

@@ -1,6 +1,6 @@
-# ?? 2015 Yannick Vaucher (Camptocamp)
-# ?? 2016 Damien Crier (Camptocamp)
-# ?? 2016 Julien Coux (Camptocamp)
+# © 2015 Yannick Vaucher (Camptocamp)
+# © 2016 Damien Crier (Camptocamp)
+# © 2016 Julien Coux (Camptocamp)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).-
 
 from . import abstract_report

account_financial_report/report/abstract_report.py

@@ -143,7 +143,9 @@ def _get_accounts_data(self, accounts_ids):
         return accounts_data
 
     def _get_journals_data(self, journals_ids):
-        journals = self.env["account.journal"].browse(journals_ids)
+        journals = self.env["account.journal"].search_fetch(
+            [("id", "in", journals_ids)], ["code"]
+        )
         journals_data = {}
         for journal in journals:
             journals_data.update({journal.id: {"id": journal.id, "code": journal.code}})

account_financial_report/report/abstract_report_xlsx.py

@@ -1,6 +1,6 @@
 # Author: Julien Coux
 # Copyright 2016 Camptocamp SA
-# Copyright 2021 Tecnativa - Jo??o Marques
+# Copyright 2021 Tecnativa - João Marques
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from odoo import models
 
@@ -571,7 +571,7 @@ def _get_currency_amt_header_format(self, line_object, report_data):
         """Return amount header format for each currency."""
         format_amt = report_data["formats"]["format_header_amount"]
         if line_object.currency_id:
-            field_name = "format_header_amount_%s" % line_object.currency_id.name
+            field_name = f"format_header_amount_{line_object.currency_id.name}"
             if hasattr(self, field_name):
                 format_amt = getattr(self, field_name)
             else:
@@ -589,7 +589,7 @@ def _get_currency_amt_header_format_dict(self, line_object, report_data):
         """Return amount header format for each currency."""
         format_amt = report_data["formats"]["format_header_amount"]
         if line_object["currency_id"]:
-            field_name = "format_header_amount_%s" % line_object["currency_name"]
+            field_name = f"format_header_amount_{line_object['currency_name']}"
             if hasattr(self, field_name):
                 format_amt = getattr(self, field_name)
             else:

account_financial_report/report/aged_partner_balance.py

@@ -1,4 +1,4 @@
-# ?? 2016 Julien Coux (Camptocamp)
+# © 2016 Julien Coux (Camptocamp)
 # Copyright 2020 ForgeFlow S.L. (https://www.forgeflow.com)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
@@ -72,25 +72,21 @@ def _calculate_amounts(
         else:
             ag_pb_data[acc_id]["older"] += residual
             ag_pb_data[acc_id][prt_id]["older"] += residual
-        if due_date:
-            days_difference = abs((today - due_date).days)
-            for index, line in enumerate(interval_lines):
-                lower_limit = (
-                    0 if not index else interval_lines[index - 1].inferior_limit
-                )
-                next_line = (
-                    interval_lines[index] if index < len(interval_lines) else None
-                )
-                interval_range = self._get_values_for_range_intervals(
-                    lower_limit, next_line.inferior_limit
-                )
-                if (
-                    days_difference in interval_range
-                    or days_difference == line.inferior_limit
-                ):
-                    ag_pb_data[acc_id][line] += residual
-                    ag_pb_data[acc_id][prt_id][line] += residual
-                    break
+
+        days_difference = abs((today - due_date).days)
+        for index, line in enumerate(interval_lines):
+            lower_limit = 0 if not index else interval_lines[index - 1].inferior_limit
+            next_line = interval_lines[index] if index < len(interval_lines) else None
+            interval_range = self._get_values_for_range_intervals(
+                lower_limit, next_line.inferior_limit
+            )
+            if (
+                days_difference in interval_range
+                or days_difference == line.inferior_limit
+            ):
+                ag_pb_data[acc_id][line] += residual
+                ag_pb_data[acc_id][prt_id][line] += residual
+                break
         return ag_pb_data
 
     def _get_values_for_range_intervals(self, num1, num2):