-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] account_financial_report: general ledger account range #1165
base: 14.0
Are you sure you want to change the base?
[14.0][IMP] account_financial_report: general ledger account range #1165
Conversation
18cfd33
to
9f3cddb
Compare
It was necessary to search for the last appearance of the end_range code in case you have the same account code in two or more different companies, the index method returns the first appearance of the code, we also added some unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @OCA/accounting-maintainers |
1 similar comment
ping @OCA/accounting-maintainers |
This PR has the |
ping @WesleyOliveira98 |
9f3cddb
to
bad8897
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
bad8897
to
cabfd79
Compare
ping @OCA/accounting-maintainers |
This improvement allows filtering accounts by range in the General Ledger for chart of accounts that use a dotted format, such as
1.1.1.01
. Currently, this functionality is not available because accounts with dots fail theisdigit()
check.Brazilian Chart of Accounts Example (https://github.com/OCA/l10n-brazil/blob/14.0/l10n_br_coa_simple/data/account.account.template.csv)
General Ledger with Brazilian Accounts
When attempting to remove dots from accounts and compare them as integers using the
filtered
method, the filter does not apply correctly if the accounts have different numbers of digits (when we use thesearch
method, this isn't a problem). So, we implemented a solution where we search for the position of each account in the chart of accounts, finding the position of thestart_range
account and theend_range
account, and then retrieve the accounts between these positions.cc: @marcelsavegnago @kaynnan @Matthwhy