[16.0][FIX] account_avatax_sale_oca: Avoid reset of order line price after saving #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found a bug where the price when the decimal accuracy was 5, the price would be automatically reset to the pricelist price after saving the order. The reason was a wrong implementation of onchange_reset_avatax_amount. In this test we demonstrate that the error does not happen anymore.
|
Hi @dreispt, |
We have observed that when we change the Product Unit of Measure to 5 decimals, and we have a pricelist in the product, when the price is manually set by the user and the order is saved, the price is reset to the product pricelist price. The reason is that the change made to order_line during the onchange_reset_avatax_amount in the sale.order. In order to fix this, we do not change the order_line during the onchange_reset_avatax_amount in sale.order, but at the time of saving, in the write method.
|
See how after the second commit the tests now pass. |
dreispt
approved these changes
Jul 15, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c486aa5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a bug where the price when the decimal accuracy was 5, the price would be automatically reset to the pricelist price after saving the order. The reason was a wrong implementation of onchange_reset_avatax_amount. In this test we demonstrate that the error does not happen anymore.
The PR contains 2 commits: