Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_bank_from_iban: Migration to 18.0 #217

Open
wants to merge 34 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] base_bank_from_iban: Migration to 18.0 #217

wants to merge 34 commits into from

Commits on Nov 19, 2024

  1. [ADD] base_bank_from_iban: Get bank from IBAN number (OCA#32)

    @carlosdauden @achulii
    carlosdauden authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2f41e8a View commit details
    Browse the repository at this point in the history

  2. [MIG] base_bank_from_iban: Migration to 12.0

    @pedrobaeza @achulii
    pedrobaeza authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    af26430 View commit details
    Browse the repository at this point in the history

  3. [IMP] base_bank_from_iban: black, isort

    @emagdalenaC2i @achulii
    emagdalenaC2i authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0b3b3f6 View commit details
    Browse the repository at this point in the history

  4. [MIG] base_bank_from_iban: Migration to 13.0

    @emagdalenaC2i @achulii
    emagdalenaC2i authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    33c6372 View commit details
    Browse the repository at this point in the history

  5. pre-commit update

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a092cc1 View commit details
    Browse the repository at this point in the history

  6. [MIG] base_bank_from_iban: Migration to 14.0

    @ozono @achulii
    ozono authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    acd064d View commit details
    Browse the repository at this point in the history

  7. Added translation using Weblate (Dutch)

    @bosd @achulii
    bosd authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a4f5871 View commit details
    Browse the repository at this point in the history

  8. Translated using Weblate (Dutch) 

    Currently translated at 100.0% (7 of 7 strings)

Translation: community-data-files-14.0/community-data-files-14.0-base_bank_from_iban
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-14-0/community-data-files-14-0-base_bank_from_iban/nl/
    @bosd @achulii
    bosd authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b6b0514 View commit details
    Browse the repository at this point in the history

  9. [MIG]base_bank_from_iban: Migration to 15.0

    @manuelregidor @achulii
    manuelregidor authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4bab92a View commit details
    Browse the repository at this point in the history

  10. [IMP] base_bank_from_iban: Promote to mature 

    It complies with the requirements and other modules depending on it are also mature.
    @pedrobaeza @achulii
    pedrobaeza authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    338901f View commit details
    Browse the repository at this point in the history

  11. [MIG] base_bank_from_iban: Migration to 16.0

    @pegonzalezspesol @achulii
    pegonzalezspesol authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f0490a5 View commit details
    Browse the repository at this point in the history

  12. [MIG] base_bank_from_iban: Finish migration 

    - Regenerate README
- Journal code removed, as you cannot specify the bank account number
  from it.
- Added the equivalente code for the add bank account wizard.

TT40005
    @pedrobaeza @achulii
    pedrobaeza authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0f69879 View commit details
    Browse the repository at this point in the history

  13. [UPD] Update base_bank_from_iban.pot

    @achulii
    oca-ci authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b1cd068 View commit details
    Browse the repository at this point in the history

  14. [UPD] README.rst

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9ab132b View commit details
    Browse the repository at this point in the history

  15. Update translation files 

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/
    @weblate @achulii
    weblate authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    78e9458 View commit details
    Browse the repository at this point in the history

  16. Added translation using Weblate (Croatian)

    @badbole @achulii
    badbole authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    94c9b47 View commit details
    Browse the repository at this point in the history

  17. Translated using Weblate (Croatian) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/hr/
    @badbole @achulii
    badbole authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8c95c35 View commit details
    Browse the repository at this point in the history

  18. Added translation using Weblate (Spanish)

    @Gelo-fl @achulii
    Gelo-fl authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e07da32 View commit details
    Browse the repository at this point in the history

  19. Translated using Weblate (Spanish) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/es/
    @Gelo-fl @achulii
    Gelo-fl authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ca643b8 View commit details
    Browse the repository at this point in the history

  20. *

    @len-foss @achulii
    len-foss authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    84f3927 View commit details
    Browse the repository at this point in the history

  21. [UPD] README.rst

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b52aedb View commit details
    Browse the repository at this point in the history

  22. [BOT] post-merge updates

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    fee0340 View commit details
    Browse the repository at this point in the history

  23. [IMP] base_bank_from_iban: pre-commit auto fixes

    @javierobcn @achulii
    javierobcn authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d76faa9 View commit details
    Browse the repository at this point in the history

  24. [MIG] base_bank_from_iban: Migration to 17.0

    @javierobcn @achulii
    javierobcn authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    049475d View commit details
    Browse the repository at this point in the history

  25. [UPD] Update base_bank_from_iban.pot

    @achulii
    oca-ci authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4c4f6e1 View commit details
    Browse the repository at this point in the history

  26. [BOT] post-merge updates

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    79491f3 View commit details
    Browse the repository at this point in the history

  27. Added translation using Weblate (Italian)

    @mymage @achulii
    mymage authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d0e266b View commit details
    Browse the repository at this point in the history

  28. Translated using Weblate (Italian) 

    Currently translated at 100.0% (4 of 4 strings)

Translation: community-data-files-17.0/community-data-files-17.0-base_bank_from_iban
Translate-URL: https://translation.odoo-community.org/projects/community-data-files-17-0/community-data-files-17-0-base_bank_from_iban/it/
    @mymage @achulii
    mymage authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ac0c356 View commit details
    Browse the repository at this point in the history

  29. [FIX] base_bank_from_iban: dependencies

    @Tisho99 @achulii
    Tisho99 authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    85b81b3 View commit details
    Browse the repository at this point in the history

  30. [BOT] post-merge updates

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    42c4f0d View commit details
    Browse the repository at this point in the history

  31. [FIX] base_bank_from_iban: Handle correctly non IBAN accounts 

    If any non IBAN account is provided, there's an ugly log with traceback
each time, polluting tests and system logs:

```
INFO prod odoo.addons.base_bank_from_iban.models.res_partner_bank: Could not find bank from IBAN
Traceback (most recent call last):
  File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 34, in _add_bank_vals
    bank = self._get_bank_from_iban(vals["acc_number"])
  File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 42, in _get_bank_from_iban
    iban = schwifty.IBAN(acc_number)
  File ".../python/site-packages/schwifty/iban.py", line 77, in __init__
    self.validate(validate_bban)
  File ".../python/site-packages/schwifty/iban.py", line 175, in validate
    self._validate_characters()
  File ".../python/site-packages/schwifty/iban.py", line 185, in _validate_characters
    raise exceptions.InvalidStructure(f"Invalid characters in IBAN {self!s}")
schwifty.exceptions.InvalidStructure: Invalid characters in IBAN XXXXXX
```

This commit removes that traceback catching the proper exception, and
handling it accordingly, and also removing an extra INFO log that was
not adding value.
    @pedrobaeza @achulii
    pedrobaeza authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2931fa9 View commit details
    Browse the repository at this point in the history

  32. [BOT] post-merge updates

    @OCA-git-bot @achulii
    OCA-git-bot authored and achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7ae4a5b View commit details
    Browse the repository at this point in the history

  33. [IMP] base_bank_from_iban: pre-commit auto fixes

    @achulii
    achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d5a74fc View commit details
    Browse the repository at this point in the history

  34. [MIG] base_bank_from_iban: Migration to 18.0

    @achulii
    achulii committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b345a56 View commit details
    Browse the repository at this point in the history