Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice_recurring: Migration to 17.0 #1174

Merged
merged 138 commits into from
Apr 22, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Apr 16, 2024

Module migrated to version 17.0

cc https://github.com/APSL 154100

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

brian10048 and others added 30 commits April 16, 2024 07:43
minor UI improvements
Currently translated at 5.1% (7 of 136 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/de/
Currently translated at 11.7% (16 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/de/
Currently translated at 13.9% (19 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/de/
Currently translated at 71.5% (98 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/de/
In the test script, there was an error in the logic which determined the week of the month.  Tests were passing before, but due to the bug, the tests fail when the first day of month is a Sunday
Currently translated at 37.2% (51 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/es_CL/
Currently translated at 83.9% (115 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/es_CL/
Currently translated at 86.1% (118 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/pt_BR/
Currently translated at 100.0% (137 of 137 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_recurring/pt_BR/
OCA-git-bot and others added 6 commits April 16, 2024 07:43
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-16.0/field-service-16.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_recurring/
Currently translated at 100.0% (145 of 145 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_recurring/es/
Currently translated at 100.0% (145 of 145 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_recurring/it/
Currently translated at 100.0% (145 of 145 strings)

Translation: field-service-16.0/field-service-16.0-fieldservice_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-16-0/field-service-16-0-fieldservice_recurring/es_AR/
@peluko00 peluko00 mentioned this pull request Apr 16, 2024
47 tasks
@peluko00 peluko00 force-pushed the 17.0-mig-fieldservice_recurring branch from e6d03dd to ea962dd Compare April 16, 2024 06:22
@OCA-git-bot
Copy link
Contributor

Hi @max3903,
some modules you are maintaining are being modified, check this out!

@peluko00 peluko00 changed the title [17.0][MIG] fieldservice recurring: Migration to 17.0 [17.0][MIG] fieldservice_recurring: Migration to 17.0 Apr 16, 2024
@max3903 max3903 added this to the 17.0 milestone Apr 16, 2024
@max3903
Copy link
Member

max3903 commented Apr 16, 2024

/ocabot migration fieldservice_recurring

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally working, checked in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@peluko00
Copy link
Contributor Author

Hi @max3903, is ready to merge?

@max3903
Copy link
Member

max3903 commented Apr 22, 2024

@peluko00 Yes!

@max3903
Copy link
Member

max3903 commented Apr 22, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1174-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1699242 into OCA:17.0 Apr 22, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 948f62e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.