Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice_portal: Migration to 17.0 #1252

Open
wants to merge 7 commits into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Oct 28, 2024

@max3903 max3903 added this to the 17.0 milestone Oct 29, 2024
@max3903 max3903 self-assigned this Oct 29, 2024
@max3903
Copy link
Member

max3903 commented Oct 29, 2024

@peluko00 Not a show stopper, but if you can add some description and the FSM icon on the portal that would look much nicer and consistent:
image

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00
Copy link
Contributor Author

@peluko00 Not a show stopper, but if you can add some description and the FSM icon on the portal that would look much nicer and consistent: image

Done, thanks!

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants