Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] fieldservice_timeline #521

Conversation

murtuzasaleh
Copy link
Member

Depends on OCA/web#1470
fieldservice #513

@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @max3903,
some modules you are maintaining are being modified, check this out!

@murtuzasaleh murtuzasaleh force-pushed the 13.0-ADD-fieldservice_web_timeline_view branch from fdc9b32 to 93d480d Compare March 12, 2020 12:57
@@ -0,0 +1,221 @@
odoo.define('fieldservice_web_timeline_view.fsm_gantt', function (require) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this JS here? Isn't the Timeline feature already provided by the Web Timeline dependency module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web Timeline module JS is extended here because of display FSM Person and Stage wise color (Order) in Timeline View.

web_timeline

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, you can already put what you want on each timeline item through QWeb templates. See https://github.com/OCA/project/blob/12.0/project_timeline_hr_timesheet/views/project_task_view.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza , @dreispt

We have done customization on web_timeline view for extra field-service features:-

  1. Added a custom filter functionality.
  2. Customize color functionality with a stage, in a stage, In an fsm.stage has choose_color field, and this field color display in an FSM order record timeline view.
  3. All-time line view line display in a top bar.
  4. Display All FSM workers in a timeline view so easily assign an order.

@pedrobaeza
Copy link
Member

Why not calling the module simply fieldservice_timeline?

@murtuzasaleh
Copy link
Member Author

Why not calling the module simply fieldservice_timeline?

Ok, I will update it.

@pedrobaeza pedrobaeza added this to the 13.0 milestone Mar 16, 2020
@max3903 max3903 requested a review from wolfhall April 9, 2020 13:04
@murtuzasaleh murtuzasaleh force-pushed the 13.0-ADD-fieldservice_web_timeline_view branch from 93d480d to 93897d7 Compare April 30, 2020 11:30
@brian10048
Copy link
Contributor

@murtuzasaleh - The OCA web_timeline is now merged OCA/web#1557

@murtuzasaleh murtuzasaleh force-pushed the 13.0-ADD-fieldservice_web_timeline_view branch from 285a184 to 53dfd58 Compare October 16, 2020 07:20
@murtuzasaleh murtuzasaleh changed the title [13.0][ADD] fieldservice_web_timeline_view [13.0][ADD] fieldservice_timeline Oct 16, 2020
@osi-scampbell
Copy link
Contributor

@murtuzasaleh hello Murtuza, can you give us an update on this PR?

@bodedra
Copy link
Member

bodedra commented Nov 20, 2020

Ping @murtuzasaleh @osi-scampbell

@brian10048 brian10048 linked an issue Jan 16, 2021 that may be closed by this pull request
43 tasks
@AmmarOfficewalaSerpentCS
Copy link
Contributor

@brian10048 , @bodedra , @osi-scampbell ,

I will work on this PR.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 13, 2022
@github-actions github-actions bot closed this Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs fixing needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to version 13.0
9 participants