Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] fieldservice_purchase #771

Merged
merged 18 commits into from
Apr 26, 2021
Merged

[13.0][MIG] fieldservice_purchase #771

merged 18 commits into from
Apr 26, 2021

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Apr 22, 2021

Migration of fieldservice_purchase to 13.0

#354

osi-scampbell and others added 16 commits April 22, 2021 10:40
@osi-scampbell @baimont
[ADD] fieldservice_purchase
b7c4f26
@OCA-git-bot @baimont
[UPD] README.rst
0e49ca7
@osi-scampbell @baimont
[IMP] Bug OCA#266 False ETA Error
20bb6e2 
[IMP] Bug OCA#265 Linked Location Search Error

[IMP] Bug OCA#272 Rate Not Declared

[IMP] Bug OCA#263 equipment_count Wrong

[IMP] Bug OCA#277 Worker Pricelists Computed Wrong

[IMP] Flake8 + Remove Debug
@max3903 @baimont
Update fsm_person.py
7f8c263
@OCA-git-bot @baimont
[UPD] README.rst
4ce982a
@oca-travis @baimont
[UPD] Update fieldservice_purchase.pot
d9bab08
@marylla @baimont
Added translation using Weblate (German)
b4e191c
@marylla @baimont
Translated using Weblate (German)
7aa17dc 
Currently translated at 100.0% (3 of 3 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_purchase
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_purchase/de/
@marcelsavegnago @baimont
Added translation using Weblate (Portuguese (Brazil))
2e6e5e2
@baimont
Added translation using Weblate (Spanish (Chile))
de0601e
@baimont
Translated using Weblate (Spanish (Chile))
12bf198 
Currently translated at 100.0% (3 of 3 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_purchase
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_purchase/es_CL/
@marcelsavegnago @baimont
Translated using Weblate (Portuguese (Brazil))
66956ec 
Currently translated at 100.0% (3 of 3 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_purchase
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_purchase/pt_BR/
@max3903 @baimont
[FIX] fieldservice_purchase: Access rights
01087cd
@dreispt @baimont
[FIX] fieldservice_purchase: Access rights
9658dd4
@OCA-git-bot @baimont
fieldservice_purchase 12.0.1.1.0
40075b9
@baimont
[IMP] fieldservice_purchase: black, isort, prettier
b251b21
@baimont baimont force-pushed the 13.0-mig-fieldservice_purchase branch from 5c2f004 to bba43e7 Compare April 22, 2021 09:40
@baimont
Copy link
Contributor Author

baimont commented Apr 22, 2021

I understand that this branch is red because of code coverage. And the branch needs tests.
But I'm wondering, why weren't there any test? Was the branch green for v12.0 without test?

@brian10048
Copy link
Contributor

brian10048 commented Apr 22, 2021 •
edited
Loading

@baimont We do not have tests for all modules, which is why many are still in Beta status in the manifest. If you are able to add tests to this module, it would be greatly appreciated!

@brian10048 brian10048 added this to the 13.0 milestone Apr 22, 2021
@brian10048 brian10048 mentioned this pull request Apr 22, 2021
Open
43 tasks
@baimont baimont force-pushed the 13.0-mig-fieldservice_purchase branch from bba43e7 to 576d641 Compare April 26, 2021 08:07
@baimont baimont requested a review from brian10048 April 26, 2021 08:08
@baimont baimont force-pushed the 13.0-mig-fieldservice_purchase branch from 576d641 to b0a474b Compare April 26, 2021 08:15
@baimont baimont force-pushed the 13.0-mig-fieldservice_purchase branch from b0a474b to 613977e Compare April 26, 2021 09:36
marcelsavegnago
marcelsavegnago approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hparfr
Copy link
Contributor

hparfr commented Apr 26, 2021

/ocabot merge nodump

@OCA-git-bot
Copy link
Contributor

Hi @hparfr. Your command failed:

Invalid options for command merge: nodump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump

More information

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-771-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 512dbfa into OCA:13.0 Apr 26, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 69f425a. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 13.0-mig-fieldservice_purchase branch May 5, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian10048 brian10048 brian10048 approved these changes

@hparfr hparfr hparfr approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@bodedra bodedra Awaiting requested review from bodedra

Assignees

@baimont baimont

Labels
approved merged 🎉 migration
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
10 participants
@baimont @brian10048 @hparfr @OCA-git-bot @marcelsavegnago @osi-scampbell @max3903 @oca-travis @marylla @dreispt