[MIG][17.0] document_page_approval #498

EdgarRetes · 2024-10-02T17:16:02Z

(../7.0pageapproval/ rev 1) fix status bar in page approval (../7.0pageapproval/ rev 2) change approval workflow in page history and started to add showing approved page in normal page (../7.0pageapproval/ rev 3) show last approved content and aproved by (../7.0pageapproval/ rev 4) Fix bug on page creation (../7.0pageapproval/ rev 5) add status in history tree view (../7.0pageapproval/ rev 6) add a need approval field and hide the workflow when no approval needed (../7.0pageapproval/ rev 7) add access validation to approval (../7.0pageapproval/ rev 8) give rigth to Page aprover group on the page_history model and hide the button for unallowed group thought the security isn't enforced a the orm level (../7.0pageapproval/ rev 9) made invisible the prover group when not needed (../7.0pageapproval/ rev 10) add email to aprovers group's members (../7.0pageapproval/ rev 11)

[ADD] Translation file + french [FIX] employee_id field does not exist [FIX] user_email field deprecated [IMP] Split long lines [ADD] Images

fix act_draft and minor ui fix remove unused variables change order of xml data files

It should work but further errors could help understand what's going Commented other necessary part Add back workflow Add dependency to knowledge

[IMP] - Improved views to match document_page improvements. [IMP] - Added notification to followers when a new version is approved. [ADD] - Updated document_page_approval pot and added es translations. [IMP] - document_page_approval: Updated spanish translation.

…te module is installed.

* Lint error corrected * test improved * lint error corrected in test file * readme corrected * test improved * test of document page history workflow added * CI error corrected * dreipst comment * Migration to new api improved in model's file and data tag remove in xml file * code totally migrate to odoo 9.0 api * test bug fixed * test error fixed * Lint error improved

…ovements on documents (OCA#155)

* Rename classes and files to match model names, and removed workflow engine. * Some fields should be readonly if not in draft. * Allow Knowledge / Manager to edit previous history names and summary * Improve ux by adding user_has_drafts to document pages. * Changes because of implementation of active field on document_page * Add ir.rules for document.page.history * Allow to quickly cancel&draft from 'to approve' state * FIX BUG: am_i_approver was being run as sudo(), hence always giving the user Approving rights. * FIX hooks Because of default='draft' on the state field, state IS NULL wasn't selecting anything. Left the condition in case this is changed in the future.

[ADD] icon.png

Add the the group eployee to the rule "Change Request Global" to allow to the user with the rule "Change Request Approver" to create pages

[UPD] Update document_page_approval.pot

To pass test is necesary set approval required to False in demo data

… commits

[UPD] Update document_page_approval.pot [UPD] README.rst

…priority)

TT36950

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Currently translated at 100.0% (60 of 60 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/pt/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/sv/

max3903 · 2024-10-08T17:25:20Z

/ocabot migration document_page_approval

max3903 · 2024-10-08T18:30:31Z

@EdgarRetes I get an error message when editing a controlled category:
AttributeError: 'document.page.history' object has no attribute 'message_post_with_template'

max3903 · 2024-10-08T20:39:32Z

/ocabot migration document_page_approval

victoralmau

Code review:

The document_page changes must be correct and not just comment code.
Can you update the example images (they are quite old)?
All changes must be in the Migration to 17.0 commit
Can you squahs the administrative commits?

victoralmau · 2024-11-06T11:41:20Z

document_page_approval/models/document_page.py

+        action = self.env.ref("document_page_approval.action_change_requests")
+        action = action.sudo().read()[0]


Suggested change

action = self.env.ref("document_page_approval.action_change_requests")

action = action.sudo().read()[0]

action = self.env["ir.actions.act_window"]._for_xml_id(

"document_page_approval.action_change_requests"

)

victoralmau · 2024-11-06T11:49:06Z

document_page_approval/security/ir.model.access.csv

@@ -0,0 +1 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink


This empty file makes no sense, I think the best thing to do is to delete it.

I think this file is necessary for the tests

It is not necessary and does nothing, remove it.

victoralmau · 2024-11-06T11:50:11Z

document_page_approval/views/document_page_approval.xml

+                        type="object"
+                        string="Send to Review"
+                        class="oe_highlight"
+                        invisible="not is_approval_required or not am_i_owner or state not in 'draft'"


Suggested change

invisible="not is_approval_required or not am_i_owner or state not in 'draft'"

invisible="not is_approval_required or not am_i_owner or state != 'draft'"

victoralmau · 2024-11-06T11:50:38Z

document_page_approval/views/document_page_approval.xml

+                        name="action_draft"
+                        type="object"
+                        string="Back to draft"
+                        invisible="(not am_i_owner or not am_i_approver) and (state not in 'cancelled')"


Suggested change

invisible="(not am_i_owner or not am_i_approver) and (state not in 'cancelled')"

invisible="(not am_i_owner or not am_i_approver) and (state != 'cancelled')"

victoralmau · 2024-11-06T11:50:49Z

document_page_approval/views/document_page_approval.xml

+                        name="action_draft"
+                        type="object"
+                        string="Back to draft"
+                        invisible="(not am_i_owner or not am_i_approver) and (state not in 'to approve')"


Suggested change

invisible="(not am_i_owner or not am_i_approver) and (state not in 'to approve')"

invisible="(not am_i_owner or not am_i_approver) and (state != 'to approve')"

victoralmau · 2024-11-07T07:29:19Z

document_page/models/document_page_history.py

@@ -66,11 +66,5 @@ def _get_diff(self, v1, v2):
                context=True,
            )

-    # TODO: Replace for _compute_display_name
    def name_get(self):


Remove the name_get() method, but do NOT remove the _compute_display_name() method. That's what is stated in the migration guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

victoralmau · 2024-11-07T07:33:59Z

document_page_approval/security/ir.model.access.csv

@@ -0,0 +1 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink


It is not necessary and does nothing, remove it.

victoralmau · 2024-11-12T09:47:13Z

Superseded by #509

cloutierjo and others added 30 commits October 2, 2024 10:39

[IMP] Documentation

3ee4bf6

[ADD] Translation file + french [FIX] employee_id field does not exist [FIX] user_email field deprecated [IMP] Split long lines [ADD] Images

Set document_page_approval as unported

aaf0251

start porting

41d03b8

fix act_draft and minor ui fix remove unused variables change order of xml data files

Comment workflow that cause the error

08183ae

It should work but further errors could help understand what's going Commented other necessary part Add back workflow Add dependency to knowledge

[FIX] - document-page-approval: Fixes OCA#60 url not valid when websi…

46cb817

…te module is installed.

[MIG] document_page_approval: Migration to 10.0

b7ff569

[FIX] View

18baa07

[IMP][10.0][document_page_approval] Change Requests and workflow impr…

71a34dd

…ovements on documents (OCA#155)

[MIG] document_page_approval: Migration to 11.0

5fdd373

[FIX] pylint/javascript-lint

b9ce469

[ADD] icon.png

[FIX] document_page_aproval: Modify in records rules

8759586

Add the the group eployee to the rule "Change Request Global" to allow to the user with the rule "Change Request Approver" to create pages

[MIG] document_page_approval: Migration to v12

48d178e

[UPD] Update document_page_approval.pot

[IMP] document_page_approval: black, isort

3e7f9c6

Migrate to 13.0 document_page_approval

872c04e

To pass test is necesary set approval required to False in demo data

[IMP] document_page_approval: black, isort, prettier + squashed admin…

c00d84d

… commits

[MIG] document_page_approval: Migration to 14.0

5b925c1

[UPD] Update document_page_approval.pot [UPD] README.rst

[FIX] document_page_approval: Avoid W7940 (dangerous-view-replace-wo-…

b3438f3

…priority)

[MIG] document_page_approval: Migration to 15.0

94e5497

TT36950

[UPD] Update document_page_approval.pot

3128936

[UPD] README.rst

632eb77

[16.0][MIG] document_page_approval: Migration to 16.0

721246a

[UPD] Update document_page_approval.pot

405afc8

[UPD] README.rst

0aa0d10

Update translation files

86d8d44

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Translated using Weblate (Italian)

6f4afbe

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Translated using Weblate (Italian)

3d0159e

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

OCA-git-bot and others added 14 commits October 2, 2024 10:39

[UPD] README.rst

a671bf4

Update translation files

5360967

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Translated using Weblate (Italian)

00f49dd

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

Translated using Weblate (Spanish)

9bd51b6

Currently translated at 100.0% (61 of 61 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

[UPD] Update document_page_approval.pot

36c87a2

Update translation files

a05454f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Translated using Weblate (Portuguese)

4396bcb

Currently translated at 100.0% (60 of 60 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/pt/

[UPD] Update document_page_approval.pot

3bd9fbd

Update translation files

1772b75

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/

Translated using Weblate (Italian)

ffe2e51

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/it/

[FIX] document_page_approval: Add correct followers in history pages

2f627e1

[BOT] post-merge updates

4a06f4a

Translated using Weblate (Spanish)

0ea1636

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/es/

Translated using Weblate (Swedish)

cb0ad1b

Currently translated at 100.0% (62 of 62 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_approval Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_approval/sv/

max3903 added this to the 17.0 milestone Oct 8, 2024

max3903 added needs review migration labels Oct 8, 2024

max3903 self-assigned this Oct 8, 2024

OCA-git-bot mentioned this pull request Oct 8, 2024

Migration to version 17.0 #442

Open

9 tasks

victoralmau suggested changes Nov 6, 2024

View reviewed changes

EdgarRetes force-pushed the 17.0-mig-document_page_approval branch from bcf2c25 to 416b8e4 Compare November 6, 2024 20:37

[MIG] document_page_approval: Migration to 17.0

81725ef

EdgarRetes force-pushed the 17.0-mig-document_page_approval branch from 416b8e4 to 81725ef Compare November 6, 2024 20:52

victoralmau suggested changes Nov 7, 2024

View reviewed changes

victoralmau mentioned this pull request Nov 12, 2024

[17.0][MIG] document_page_approval: Migration to 17.0 #509

Merged

8 tasks

max3903 closed this Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][17.0] document_page_approval #498

[MIG][17.0] document_page_approval #498

EdgarRetes commented Oct 2, 2024

max3903 commented Oct 8, 2024

max3903 commented Oct 8, 2024

max3903 commented Oct 8, 2024

victoralmau left a comment

victoralmau Nov 6, 2024

victoralmau Nov 6, 2024

EdgarRetes Nov 6, 2024

victoralmau Nov 7, 2024

victoralmau Nov 6, 2024

victoralmau Nov 6, 2024

victoralmau Nov 6, 2024

victoralmau Nov 7, 2024

victoralmau Nov 7, 2024

victoralmau commented Nov 12, 2024

		action = self.env.ref("document_page_approval.action_change_requests")
		action = action.sudo().read()[0]

		@@ -0,0 +1 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink

	invisible="not is_approval_required or not am_i_owner or state not in 'draft'"
	invisible="not is_approval_required or not am_i_owner or state != 'draft'"

	invisible="(not am_i_owner or not am_i_approver) and (state not in 'cancelled')"
	invisible="(not am_i_owner or not am_i_approver) and (state != 'cancelled')"

[MIG][17.0] document_page_approval #498

[MIG][17.0] document_page_approval #498

Conversation

EdgarRetes commented Oct 2, 2024

max3903 commented Oct 8, 2024

max3903 commented Oct 8, 2024

max3903 commented Oct 8, 2024

victoralmau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victoralmau commented Nov 12, 2024