-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] document_knowledge: Migration to 18.0 #503
[18.0][MIG] document_knowledge: Migration to 18.0 #503
Conversation
* Copyright and various stuff * Contributors * External ID not found in the system: base.group_document_user
Currently translated at 93.9% (31 of 33 strings) Translation: knowledge-11.0/knowledge-11.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/
It solves this: OCA#179
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Otherwise the module grants too wide permissions for all users.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/
Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-12.0/knowledge-12.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
Currently translated at 57.7% (15 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/he_IL/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
Currently translated at 100.0% (26 of 26 strings) Translation: knowledge-13.0/knowledge-13.0-knowledge Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/ru/
4d50f59
to
6b28bbe
Compare
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrobaeza a new PR that can be merge here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Controversial opinion about removing the settings part, but this is a frequent source of questions/problems cc @max3903
@@ -9,25 +9,17 @@ class DocumentKnowledgeConfigSettings(models.TransientModel): | |||
|
|||
module_attachment_indexation = fields.Boolean( | |||
"Attachments List and Document Indexation", | |||
help="Document indexation, full text search of attachements.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer that you remove all the options, as this is not valid if the rest of the modules aren't there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza Thanks for your time!!
Can you explain more so I can better understand what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that having these module_*
fields is for installing modules that are still not migrated, but even if migrated, you may not have those modules present on your Odoo instance, so clicking on the checks provoke confusion and misleading in users, so I propose to remove these fields from the configuration.
document_knowledge/readme/CREDITS.md
Outdated
@@ -1,3 +1,8 @@ | |||
The development of this module has been financially supported by: | |||
|
|||
- Camptocamp | |||
|
|||
The migration of this module from 17.0 to 18.0 was financially supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the previous text.
6b28bbe
to
986fef4
Compare
Thanks for the changes. I think you have stripped now too much, as I was just talking about |
/ocabot migration document_knowledge |
986fef4
to
f82dce4
Compare
It was my fault. I fixed it. Thanks for your time!! |
thanks @pedrobaeza for this insightful review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
Congratulations, your PR was merged at 433dcc3. Thanks a lot for contributing to OCA. ❤️ |
No description provided.