Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] document_knowledge: Migration to 18.0 #503

Merged
merged 46 commits into from
Nov 13, 2024

Conversation

Kimkhoi3010
Copy link

No description provided.

naousse and others added 30 commits October 29, 2024 17:33
* Copyright and various stuff
* Contributors
* External ID not found in the system: base.group_document_user
Currently translated at 93.9% (31 of 33 strings)

Translation: knowledge-11.0/knowledge-11.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-11-0/knowledge-11-0-knowledge/pt_BR/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Otherwise the module grants too wide permissions for all users.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/
Currently translated at 57.7% (15 of 26 strings)

Translation: knowledge-12.0/knowledge-12.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-knowledge/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
Currently translated at 57.7% (15 of 26 strings)

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/he_IL/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/
Currently translated at 100.0% (26 of 26 strings)

Translation: knowledge-13.0/knowledge-13.0-knowledge
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-knowledge/ru/
@Kimkhoi3010 Kimkhoi3010 force-pushed the 18.0-mig-document_knowledge branch 2 times, most recently from 4d50f59 to 6b28bbe Compare November 8, 2024 05:53
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houssine78
Copy link

@pedrobaeza a new PR that can be merge here :)

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controversial opinion about removing the settings part, but this is a frequent source of questions/problems cc @max3903

@@ -9,25 +9,17 @@ class DocumentKnowledgeConfigSettings(models.TransientModel):

module_attachment_indexation = fields.Boolean(
"Attachments List and Document Indexation",
help="Document indexation, full text search of attachements.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that you remove all the options, as this is not valid if the rest of the modules aren't there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza Thanks for your time!!
Can you explain more so I can better understand what you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that having these module_* fields is for installing modules that are still not migrated, but even if migrated, you may not have those modules present on your Odoo instance, so clicking on the checks provoke confusion and misleading in users, so I propose to remove these fields from the configuration.

@@ -1,3 +1,8 @@
The development of this module has been financially supported by:

- Camptocamp

The migration of this module from 17.0 to 18.0 was financially supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the previous text.

@pedrobaeza
Copy link
Member

Thanks for the changes. I think you have stripped now too much, as I was just talking about module_* fields, not the rest.

@pedrobaeza
Copy link
Member

/ocabot migration document_knowledge

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 13, 2024
@Kimkhoi3010
Copy link
Author

Thanks for the changes. I think you have stripped now too much, as I was just talking about module_* fields, not the rest.

It was my fault. I fixed it. Thanks for your time!!

@houssine78
Copy link

thanks @pedrobaeza for this insightful review.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-503-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a7eba92 into OCA:18.0 Nov 13, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 433dcc3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.