[FIX] account_banking_ach_direct_debit: fix pylint errors

OCA · Jun 18, 2024 · c2f4f9c · c2f4f9c
1 parent 2946cb4
commit c2f4f9c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/account_banking_ach_direct_debit/models/account_banking_mandate.py b/account_banking_ach_direct_debit/models/account_banking_mandate.py
@@ -37,7 +37,6 @@ class AccountBankingMandate(models.Model):
     )
     scheme = fields.Selection(
         [("CORE", "Basic (CORE)"), ("B2B", "Enterprise (B2B)")],
-        string="Scheme",
         default="CORE",
         tracking=True,
     )
@@ -49,8 +48,11 @@ def _check_recurring_type(self):
         for mandate in self:
             if mandate.type == "recurrent" and not mandate.recurrent_sequence_type:
                 raise exceptions.ValidationError(
-                    _("The recurrent mandate '%s' must have a sequence type.")
-                    % mandate.unique_mandate_reference
+                    _(
+                        "The recurrent mandate '%(mandate_reference)s' "
+                        "must have a sequence type."
+                    )
+                    % {"mandate_reference": mandate.unique_mandate_reference}
                 )
 
     @api.depends("unique_mandate_reference", "recurrent_sequence_type")

diff --git a/account_banking_ach_direct_debit/models/account_payment_order.py b/account_banking_ach_direct_debit/models/account_payment_order.py
@@ -51,8 +51,9 @@ def generated2uploaded(self):
                         "Automatically switched from <b>First</b> to "
                         "<b>Recurring</b> when the debit order "
                         "<a href=# data-oe-model=account.payment.order "
-                        "data-oe-id=%d>%s</a> has been marked as uploaded."
+                        "data-oe-id=%(order_id)d>%(order_name)s</a> "
+                        "has been marked as uploaded."
                     )
-                    % (order.id, order.name)
+                    % {"order_id": order.id, "order_name": order.name}
                 )
         return res