[17.0][MIG] account_banking_ach_base #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiMForgeFlow
force-pushed
the
17.0-mig-account_banking_ach_base
branch
from
9ad5441 to
fcf8fca
Compare
Co-authored-by: Daniel Reis <[email protected]>
…xcept space,comma and underscore because these special characters are accepted while creating a file
[FIX] account_banking_ach_base: use the payment_ids field instead of bank_line_ids Applies same fix as OCA#101 amount_currency no longer available in 16 (Changed to amount) communicaton field no longer available in 16 (Changed to ref)
JordiMForgeFlow
force-pushed
the
17.0-mig-account_banking_ach_base
branch
from
fcf8fca to
3191217
Compare
|
@OCA/local-usa-maintainers could we get some reviews here? Thank you :) |
1 task
JordiMForgeFlow
force-pushed
the
17.0-mig-account_banking_ach_base
branch
from
3191217 to
3419f48
Compare
MiquelRForgeFlow
suggested changes
Dec 19, 2024
Comment on lines
+61
to
+62
| for mandate in mandates: | ||
| mandate.set_payment_modes_on_partner() |
There was a problem hiding this comment.
Suggested change
| for mandate in mandates: | |
| mandate.set_payment_modes_on_partner() | |
| mandates.set_payment_modes_on_partner() |
It would be better if you adapt set_payment_modes_on_partner() to api.multi, as it is doing search and write inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard migration