Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] maintenance_equipment_status: Migration to 17.0 #410

Merged
merged 28 commits into from
Aug 2, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Jun 20, 2024

Module migrated to version 17.0

cc https://github.com/APSL 157017
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

JordiBForgeFlow and others added 27 commits June 20, 2024 13:32
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_status/es/
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_status/es/
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_equipment_status/it/
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-15.0/maintenance-15.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_equipment_status/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/it/
Currently translated at 95.4% (21 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/es/
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_status
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_status/es/
@peluko00 peluko00 mentioned this pull request Jun 20, 2024
17 tasks
@peluko00 peluko00 force-pushed the 17.0-mig-maintenance_equipment_status branch from 90e7c82 to 905eaa6 Compare June 20, 2024 12:57
@peluko00 peluko00 force-pushed the 17.0-mig-maintenance_equipment_status branch 2 times, most recently from 201437f to c78bd8b Compare June 21, 2024 07:15
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked in runboat

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & functional review 👍

Only one thing, not blocking, is it possible to add status field management (search & group by) to equipments search view? It could be a nice and easy improvement IMO

Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well. LGTM

@peluko00 peluko00 force-pushed the 17.0-mig-maintenance_equipment_status branch from c78bd8b to c29f67f Compare July 31, 2024 06:30
@peluko00
Copy link
Author

Seems is ready to merge @pedrobaeza ?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration maintenance_equipment_status
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 2, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-410-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dffd8ef into OCA:17.0 Aug 2, 2024
8 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c84103c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.