Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to PyPI immediately before pushing to main branch #299

Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 22, 2024

We publish to PyPI before merging, because we don't want to merge if PyPI rejects the upload for any reason (such as ownership issues). There is a possibility that the upload succeeds and then the merge fails, but that should be exceptional, and it is better than the contrary.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain legalsylvain merged commit 7e08e7f into OCA:master Oct 25, 2024
2 checks passed
@sbidoul sbidoul deleted the publish-to-pypi-before-push-to-main-branch branch October 28, 2024 07:07
@sbidoul
Copy link
Member Author

sbidoul commented Nov 27, 2024

This has been deployed earlier this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants