-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_print_category: Migration to 18.0 #1789
Open
HeliconiaSolutions
wants to merge
32
commits into
OCA:18.0
Choose a base branch
from
HeliconiaIO:18.0-mig-product_print_category
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] product_print_category: Migration to 18.0 #1789
HeliconiaSolutions
wants to merge
32
commits into
OCA:18.0
from
HeliconiaIO:18.0-mig-product_print_category
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…product and allow to print various format of labels
…d avoid checkbox to be checked during the save of the product. [REF] make the module working if a create is done directly on product.template
…e better default print category values. [REM] remove default_print_category on res.company model
…roup, because it make the default computation failing on the product.product form view if user is not member of the group. Also to align with the rest of odoo : print_category_id is a regular field that can be user by any user that is member of base.group_user as all the other field [FIX] use _for_xml_id to avoid error if user is not admin, when using the print wizard [REF] use expression.AND to simplify code
Currently translated at 100.0% (54 of 54 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_print_category Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/it/
Currently translated at 100.0% (54 of 54 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_print_category Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_print_category Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/
[IMP] product_print_category: Improve test and add contributors [FIX] product_print_category: Fix view
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-17.0/product-attribute-17.0-product_print_category Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_print_category/
on rule: print category rule user
legalsylvain
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff review. LGTM. Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.