Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_print_category: Migration to 18.0 #1789

Open
wants to merge 32 commits into
base: 18.0
Choose a base branch
from

Conversation

HeliconiaSolutions
Copy link

No description provided.

legalsylvain and others added 30 commits November 29, 2024 16:26
…product and allow to print various format of labels
…d avoid checkbox to be checked during the save of the product.

[REF] make the module working if a create is done directly on product.template
…e better default print category values.

[REM] remove default_print_category on res.company model
…roup, because it make the default computation failing on the product.product form view if user is not member of the group. Also to align with the rest of odoo : print_category_id is a regular field that can be user by any user that is member of base.group_user as all the other field

[FIX] use _for_xml_id to avoid error if user is not admin, when using the print wizard
[REF] use expression.AND to simplify code
Currently translated at 100.0% (54 of 54 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/it/
Currently translated at 100.0% (54 of 54 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_print_category/
[IMP] product_print_category: Improve test and add contributors

[FIX] product_print_category: Fix view
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-17.0/product-attribute-17.0-product_print_category
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_print_category/
on rule: print category rule user
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. LGTM. Thanks !

@remytms
Copy link

remytms commented Nov 30, 2024

Thanks for porting this module to 18.0 !

Request from my side, can you edit the commit title 195f765 and remove the meniton to me (@remytms) because I get spammed each time a commit with mention to me is push on github. :)

I will do a review of the full code soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants