[16.0][FIX] sale_tier_validation: Basic compatibility with sale_loyalty #3381
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you install sale_loyalty, this piece of code: https://github.com/odoo/odoo/blob/2a7876538e9ea630563e39ee8402b27147d1e428/addons/sale_loyalty/models/sale_order.py#L740 is always executed when confirming a sales order, so it blocks it, no matter if no coupons are being handled. This little code avoids this blocking without requiring a glue module, although further work would be needed if some coupons are applied. TT51484
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
That's very weird... Look how it looks my "Request changes":
Maybe it's because you don't have enough permissions. The key is that yours is very easy to be missed. In fact, in this PR is the same like you didn't oppose to it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Yeah, I see, then that's something I should pay attention from now on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you install
sale_loyalty, this piece of code:https://github.com/odoo/odoo/blob/2a7876538e9ea630563e39ee8402b27147d1e428/addons/sale_loyalty/models/sale_order.py#L740
is always executed when confirming a sales order, so it blocks it, no matter if no coupons are being handled.
This little code avoids this blocking without requiring a glue module, although further work would be needed if some coupons are applied.
@Tecnativa TT51484