[14.0][ADD] sale_order_line_display_stock_per_warehouse #3451
+798
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kev-Roche
force-pushed
the
14.0-add-sale_order_line_display_stock_per_warehouse
branch
2 times, most recently
from
e9f7451
to
468a9ea
Compare
Comment on lines
27
to
39
| qty_data = ( | ||
| self.env["stock.quant"] | ||
| .with_context(warehouse=warehouse.id) | ||
| .read_group( | ||
| domain=[ | ||
| ("product_id", "=", line.product_id.id), | ||
| ("location_id", "child_of", warehouse.lot_stock_id.id), | ||
| ], | ||
| fields=["quantity:sum"], | ||
| groupby=[], | ||
| )[0]["quantity"] | ||
| ) | ||
| qty_available = qty_data if qty_data else 0 |
There was a problem hiding this comment.
Make it simplier and correct.
Suggested change
| qty_data = ( | |
| self.env["stock.quant"] | |
| .with_context(warehouse=warehouse.id) | |
| .read_group( | |
| domain=[ | |
| ("product_id", "=", line.product_id.id), | |
| ("location_id", "child_of", warehouse.lot_stock_id.id), | |
| ], | |
| fields=["quantity:sum"], | |
| groupby=[], | |
| )[0]["quantity"] | |
| ) | |
| qty_available = qty_data if qty_data else 0 | |
| qty_available = line.product_id.with_context(warehouse=warehouse.id).qty_available |
With the current implementation you have the quantity that you have physically in stock. What we need is the quantity that you can sell. The field qty_available depends on the context passed in the warehouse so it' simplier to reuse this field.
There was a problem hiding this comment.
thank you for your review, I fixed it.
Kev-Roche
force-pushed
the
14.0-add-sale_order_line_display_stock_per_warehouse
branch
from
468a9ea
to
f6c1181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module to show available stock per warehouse on sale order lines