Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] stock_depot #131

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[ADD] stock_depot #131

merged 1 commit into from
Oct 8, 2024

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Jul 4, 2024 •
edited
Loading

Manage partners stock depots.

This module is a dependency of OCA/wms#915

@santostelmo santostelmo marked this pull request as draft July 4, 2024 08:34
@santostelmo santostelmo marked this pull request as ready for review July 4, 2024 11:22
cyrilmanuel
cyrilmanuel approved these changes Jul 5, 2024
View reviewed changes
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

ivantodorovich
ivantodorovich approved these changes Jul 8, 2024
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LG 👍🏻

It might be a good idea to explain the functional use case of a "partner depot", in the README

The module alone seems rather empty

@rousseldenis rousseldenis added this to the 16.0 milestone Jul 9, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux jbaudoux mentioned this pull request Oct 4, 2024
Open
@jbaudoux
Copy link

jbaudoux commented Oct 4, 2024

@santostelmo Can you do the small suggested changes from @rousseldenis and @jbaudoux ?

@jbaudoux jbaudoux mentioned this pull request Oct 4, 2024
Open
@santostelmo
Copy link
Contributor Author

@santostelmo Can you do the small suggested changes from @rousseldenis and @jbaudoux ?

Suggested changes applied.

@jbaudoux
Copy link

jbaudoux commented Oct 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-131-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 198d5a1 into OCA:16.0 Oct 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 59956a6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@SilvioC2C SilvioC2C SilvioC2C approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@santostelmo @OCA-git-bot @jbaudoux @ivantodorovich @cyrilmanuel @rousseldenis @SilvioC2C