-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] stock_picking_group_by_partner_by_carrier: Control the original_group_id propagation. #1751
Open
lmignon
wants to merge
6
commits into
OCA:16.0
Choose a base branch
from
acsone:16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
approved these changes
Oct 28, 2024
TDu
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question on the migration script, otherwise looks good
stock_picking_group_by_partner_by_carrier/migrations/16.0.2.0.0/post-migrate.py
Outdated
Show resolved
Hide resolved
…ed group When merging an outgoing picking, update only the current moves with the new procurement group. This is required to ensure that an update of the quantity on a SO will be properly applied to all the picking chain through the run of stock rules.
… propagation configurable on stock rule. In a multi steps delivery process, when you allow to group the moves linked to the same carrier and partner into the same shipping, it's important to be able to merge internal moves that could be pulled. This merge is only possible if the original_group_id is not propagated to the pulled moves. We add an option to disable the propagation on the stock.rule.
…p swap When the grouping functionality is enabled. A new procurement group is created the first time a pick out is created as merged. Every time moves from a new group are added into the picking, the merged procurement is updated to link the new group. In this way, the group is never updated after its original creation
When a backorder is created from a merged picking, a new procurement group must be created to ensure that only original sale orders and procurement group from the remaining moves are linked to the backorder.
lmignon
force-pushed
the
16.0-stock_picking_group_by_partner_by_carrier-fix_orignal_group_id_propagation-lmi
branch
from
October 30, 2024 08:15
17121f1
to
4c1f649
Compare
jbaudoux
approved these changes
Oct 31, 2024
@lmignon pre-commit to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1498 which was closed by ocabot. It works in production for months... should be nice to have-it merged