Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_pack_operation_auto_fill > stock_move_line_auto_fill #538

Closed
wants to merge 16 commits into from
Closed

[12.0][MIG] stock_pack_operation_auto_fill > stock_move_line_auto_fill #538

wants to merge 16 commits into from

Conversation

jarroyomorales
Copy link

Migration to 12.0

zakiuu and others added 13 commits June 21, 2019 11:59
@zakiuu
[9.0][IMP]stock_pack_operation_auto_fill: fill operations automatically
07cdd95
[MIG] stock_pack_operation_auto_fill: Migration to 10.0
65f76f2
@zakiuu
[10.0][REF]stock_pack_operation_auto_fill: move auto fill button to h…
cb29a5e 
…eader
@oca-transbot
OCA Transbot updated translations from Transifex
6f36224
[MIG]stock_pack_operation_auto_fill: Migration to 11.0
93b3ff3
@oca-transbot
OCA Transbot updated translations from Transifex
8cb2eff
[FIX][stock_pack_operation_auto_fill] - Wrong qty done when use diffe…
dff3eca 
…rent UoM.
@oca-travis
[UPD] Update stock_pack_operation_auto_fill.pot
840e8a3
@sergio-teruel
[11.0][IMP] stock_pack_operation_auto_fill: Merge module stock_pickin…
55f206b 
…g_transfer_lot_autoassign
@oca-travis
[UPD] Update stock_pack_operation_auto_fill.pot
7ac27e5
@OCA-git-bot
[UPD] README.rst
8276013
@chienandalu
[FIX] stock_pack_operation_auto_fill: Autofill button permissions
e0e8b77 
Only stock users should be able to process done quantities.
@oca-transbot
Update translation files
40a6597 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@rousseldenis rousseldenis added this to the 12.0 milestone Jun 24, 2019
@rousseldenis
Copy link
Contributor

Hi @jarroyomorales. Thanks for this.

As the model name has changed (and also the model description), it's better to rename it stock_move_line_auto_fill (with a migration script).

I saw the remark here :
#457

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 24, 2019
Open
34 tasks
@jarroyomorales
Copy link
Author

Hi @rousseldenis ,
I just changed the name and the description and added the rename in OpenUpgrade.
OCA/OpenUpgrade#1898
Is there anything else that needs to be done?

HaraldPanten
HaraldPanten approved these changes Jun 25, 2019
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@kittiu
Copy link
Member

kittiu commented Jun 26, 2019

Functional tested LGTM

@carlosdauden carlosdauden mentioned this pull request Jul 12, 2019
Closed
@pedrobaeza pedrobaeza changed the title [12.0][MIG] stock_pack_operation_auto_fill [12.0][MIG] stock_pack_operation_auto_fill > stock_move_line_auto_fill Jul 12, 2019
bealdav
bealdav reviewed Jul 12, 2019
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An UI improvement as suggestion

stock_move_line_auto_fill/views/stock_picking_type_views.xml Outdated Show resolved Hide resolved
@bealdav bealdav mentioned this pull request Jul 12, 2019
Merged
@jarroyomorales
Merge pull request #1 from akretion/12-auto-fill-view
12c8d4b 
IMP mv_line_auto_fill: pick type UI
@rousseldenis
Copy link
Contributor

@bealdav @pedrobaeza @kittiu Could you update your review ?

bealdav
bealdav approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion merged.
Works in production

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 12.0-ocabot-merge-pr-538-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 26, 2019
@OCA-git-bot
Merge PR #538 into 12.0
e2e3ce8 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e2e3ce8. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@rafaelbn
Copy link
Member

We should clarify @sergio-teruel if this FIX is needed here in v12 #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@kittiu kittiu kittiu left review comments

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@bealdav bealdav bealdav approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.