Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_time_range_menu_custom: Migration to 16.0 #2993

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

CarlosRoca13
Copy link
Contributor

Tardo and others added 7 commits November 18, 2024 13:39
Steps to reproduce:

- Go to pivot view
- Select a custom time range
- Select a predefined comparison period (Ex. Previous Period)

Now you see that the comparison period is not being applied.
After this commit the comparison period is applied correctly.

TT29249
@pedrobaeza
Copy link
Member

/ocabot migration web_time_range_menu_custom

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 19, 2024
46 tasks
@legalsylvain
Copy link
Contributor

Hi @CarlosRoca13 : On the runboat, I'm not sure to understand what is the feature added. Could you elaborate in a usage.rst function the way to use it ? and ideally a print screen ? Thanks !

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-MIG-web_time_range_menu_custom branch from b8b4f57 to f69a208 Compare November 19, 2024 10:48
@CarlosRoca13
Copy link
Contributor Author

Added usage and here you have a gif to see the result:

example adding filters

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-MIG-web_time_range_menu_custom branch from f69a208 to 6c47f66 Compare November 19, 2024 10:56
@legalsylvain
Copy link
Contributor

Thanks a lot ! it's very clear !

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-MIG-web_time_range_menu_custom branch from 6c47f66 to 7a9d542 Compare November 19, 2024 13:17
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working ok 👍 thanks :)

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2993-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48ce06d into OCA:16.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1bb14cd. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-MIG-web_time_range_menu_custom branch November 20, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants