[16.0][MIG] stock_warehouse_flow: Migration to 16.0 #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoBM
changed the title
|
test do not pass, this #707 is necessary before |
RodrigoBM
force-pushed
the
16.0-mig-stock_warehouse_flow
branch
from
55f1a62
to
d78cf73
Compare
|
Add this fix #705 |
jsanchezdeavila
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Functional validation
LGTM
https://www.awesomescreenshot.com/video/19771910?key=4864abd489cf337b68d79215091357ab
sebalix
reviewed
Sep 6, 2023
New feature allowing to re-qualify the operation type of a stock move at confirmation. The main criteria to requalify a move is the carrier, as this one often implies a dedicated routing (we do not have the same flow, nor the same carrier, depending if we ship a pallet or a bunch of products for instance). This job was previously done by configuring the stock_dynamic_routing with a domain on the carrier, but the dynamic routing was applied on reservation, while we could already qualify moves at confirmation.
The glue module `stock_warehouse_flow_release` is here to ensure the compatibility.
Just have the function return the same kind of recordset for every return statement
Add an error raising if there are routing flows but none are matched with the `move_domain` on the flow.
This allows to configure a split_method simple on a flow by setting also the split_qty the move get split before the apply Also if a flow is marked as simple split, it only applies on moves where the move product_qty >= split_qty
RodrigoBM
force-pushed
the
16.0-mig-stock_warehouse_flow
branch
from
d78cf73
to
7e48298
Compare
sebalix
approved these changes
Sep 7, 2023
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Thank you @RodrigoBM |
You are welcome. |
|
Congratulations, your PR was merged at 180da63. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#461