Use Dolmen type variables #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need a value field in the type variable of Alt-Ergo. These values were only used by the unification of the types in the legacy typechecker.
Halbaroth
changed the title
bclement-ocp
approved these changes
Nov 12, 2024
src/lib/structures/expr.ml
Outdated
| @@ -335,7 +335,7 @@ module SmtPrinter = struct | |||
|
|
|||
| (* This printer follows the convention used to print | |||
| type variables in the module [Ty]. *) | |||
| let pp_tyvar ppf v = Fmt.pf ppf "A%d" v | |||
| let pp_tvar ppf v = Fmt.pf ppf "A%a" DE.Ty.Var.print v | |||
There was a problem hiding this comment.
Suggested change
| let pp_tvar ppf v = Fmt.pf ppf "A%a" DE.Ty.Var.print v | |
| let pp_tvar ppf v = Fmt.pf ppf "%a" DE.Ty.Var.print v |
"A" is already added to the name of the variable in fresh_tvar, and there is no need to add a prefix to variables from the problem (once we use them).
There was a problem hiding this comment.
Indeed, it should work because it seems that we always call Ty.fresh_tvar() in Translate even if we do not need to call it on some type variables emitted by Dolmen. Otherwise, we could see type variables without this prefix. I remove the printer.
bclement-ocp
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is open to replace #1263: