New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SVGs with implicit XML namespacing #49

Open

tomkralidis wants to merge 1 commit into master from issue-47

Member

tomkralidis commented Aug 9, 2024

Fixes #47


          update SVGs with implicit XML namespacing (#47)

b58068d

tomkralidis requested a review from chris-little

August 9, 2024 00:22

Member Author

tomkralidis commented Aug 9, 2024

Note: while the SVGs do not render in the diff mode of this PR (i.e. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/pull/49/files), they do in branch view (i.e. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/tree/issue-47)

tomkralidis mentioned this pull request

svg: prefix breaks detection as SVG file #47

Open

Member

chris-little commented Aug 22, 2024 •

edited

Loading

@tomkralidis When reviewing this PR, I only see Unable to render rich display. Invalid iamge source, for every single file. Also, if I go to the code, similar error message. e.g. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/blob/master/symbols/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg
But I see the SVGs rendered in my fork in the code view. E.g. https://github.com/chris-little/WorldWeatherSymbols/blob/master/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg or via the Issue-47 https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/blob/issue-47/symbols/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet