Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new tutorial for initialisation with observed thickness #111

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

pat-schmitt
Copy link
Member

Here I have added the requested tutorial from OGGM/oggm#1655.

Open for review ;)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@anoukvlug anoukvlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pat-schmitt, this is a great addition! I enjoyed going through the tutorial and learning about this new functionality :)

I only have some minor suggestions, that I added to the respective lines. One thing we do need to keep in mind, is that the tutorial doesn't work with the latest server version option on the hub (oggm-v161-beta) yet.

"id": "028197d3-3d2f-4363-82f8-75ae37595ce6",
"metadata": {},
"source": [
"This notebook demonstrates the translation of thickness observations into bed topography in 'flowline-space' and a dynamic model initialization for projection starting points. Guidelines for adding thickness observations to your glacier directory are provided in the tutorials [Ingest gridded products such as ice velocity into OGGM](../advanced/ingest_gridded_data_on_flowlines.ipynb) and [OGGM-Shop and Glacier Directories in OGGM](../beginner/oggm_shop.ipynb)."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"This notebook demonstrates the translation of thickness observations into bed topography in 'flowline-space' and a dynamic model initialization for projection starting points. Guidelines for adding thickness observations to your glacier directory are provided in the tutorials [Ingest gridded products such as ice velocity into OGGM](../advanced/ingest_gridded_data_on_flowlines.ipynb) and [OGGM-Shop and Glacier Directories in OGGM](../beginner/oggm_shop.ipynb)."
"This notebook demonstrates the translation of thickness observations into bed topography in 'flowline-space' and a dynamic model initialization for projections. Guidelines for adding thickness observations to your glacier directory are provided in the tutorials [Ingest gridded products such as ice velocity into OGGM](../advanced/ingest_gridded_data_on_flowlines.ipynb) and [OGGM-Shop and Glacier Directories in OGGM](../beginner/oggm_shop.ipynb)."

},
"outputs": [],
"source": [
"# iniitalize our test glacier from the preprocessed directories including the shop data\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"# iniitalize our test glacier from the preprocessed directories including the shop data\n",
"# initialize our test glacier from the preprocessed directories including the shop data\n",

"source": [
"Now, we delve into the process of initializing the model using OGGM's dynamic calibration methodology, elaborated in the tutorial [Dynamic spinup and dynamic *melt_f* calibration for past simulations](../advanced/dynamical_spinup.ipynb). In summary, the approach involves dynamically aligning the RGI area by identifying a suitable glacier state in the past and dynamically adjusting the melt factor of the mass balance to match observed geodetic mass balance. With the glacier bed defined by observations, there is an additional capability to dynamically match for the volume (further details below).\n",
"\n",
"To commence, use the dynamic calibration function `run_dynamic_melt_f_calibration` in conjunction with the newly created flowlines, which can be passed to `init_model_fls`. Refer to the designated tutorial for more details on the other parameters."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to add the link and name of the tutorial there is being referred to.

@pat-schmitt
Copy link
Member Author

@anoukvlug thank you for the review, I added your points to the tutorial.

And yes we must keep in mind that the tutorial only works with a very recent version of OGGM and that we could delete a cell in the notebook once the preprocessed directories are updated (related to OGGM/oggm#1660).

@fmaussion fmaussion merged commit 3f6143a into OGGM:master Jan 5, 2024
1 check passed
@fmaussion
Copy link
Member

Thanks a lot @pat-schmitt , fantastic addition

@pat-schmitt pat-schmitt deleted the add_thickness_obs_tutorial branch February 28, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants