Diffuse/specular parameters are mixed incorrectly. Or not? #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WHAT THE...?!?! Yes this a bug. I know that the ambient hemisphere lighting is just a hack, but still... I'll have to evaluate how much impact it makes on the scenes because it seems to be significant enough to be mentioned by the documentation. Release 3.0 will also be making a change to PBR so it'd be great if we can include it with that release. |
|
I've finally had some time to look into this. Due to how significant this change can be, I added the ability to switch between the old and new method. Thank you for your PR! It's been merged by hand. |
|
Holy f*ing cow 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffuse/specular parameters are mixed incorrectly. Or not?
In any case, there are visible differences.
Left picture as it is. Right picture with my changes.
I have only set ambient light in the scene:
sceneManager->setAmbientLight( Ogre::ColourValue( 1.0f, 0.0f, 0.0f ), Ogre::ColourValue( 1.0f, 1.0f, 1.0f ), Ogre::Vector3::UNIT_Y);