Finish removing bit64

OHDSI · Aug 29, 2024 · 2f5ccc1 · 2f5ccc1
1 parent a60cd3b
commit 2f5ccc1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -17,7 +17,6 @@ Depends:
   R (>= 3.6.0),
   R6
 Imports:
-  bit64,
   checkmate,
   digest,
   dplyr,

diff --git a/tests/testthat/test-CohortConstructionAndStats.R b/tests/testthat/test-CohortConstructionAndStats.R
@@ -398,8 +398,6 @@ test_that("Insert cohort stats expected use-case", {
     table = cohortTableNames$cohortInclusionTable,
     snakeCaseToCamelCase = TRUE
   )
-  # HACK: SqlLite does not support bigint so convert the results returned
-  results$cohortDefinitionId <- bit64::as.integer64(results$cohortDefinitionId)
   expect_equal(results, cohortInclusionRules)
   DatabaseConnector::disconnect(conn)
 })
@@ -465,8 +463,6 @@ test_that("Insert cohort stats with inclusion rule name that is empty", {
     table = cohortTableNames$cohortInclusionTable,
     snakeCaseToCamelCase = TRUE
   )
-  # HACK: SqlLite does not support bigint so convert the results returned
-  results$cohortDefinitionId <- bit64::as.integer64(results$cohortDefinitionId)
   expect_equal(results, cohortInclusionRules)
   DatabaseConnector::disconnect(conn)
 })
@@ -506,8 +502,6 @@ test_that("Insert cohort stats with INT64 for cohort_definition_id", {
   # Obtain a list of cohorts to test
   cohortsWithStats <- getCohortsForTest(cohorts, generateStats = TRUE)
 
-  # Hack the cohortDefinitionId to force to 64 bit integer
-  cohortsWithStats$cohortId <- bit64::as.integer64(cohortsWithStats$cohortId)
   cohortsWithStats$cohortId <- cohortsWithStats$cohortId + .Machine$integer.max
 
   # Insert the inclusion rule names
@@ -526,8 +520,6 @@ test_that("Insert cohort stats with INT64 for cohort_definition_id", {
     table = cohortTableNames$cohortInclusionTable,
     snakeCaseToCamelCase = TRUE
   )
-  # HACK: SqlLite does not support bigint so convert the results returned
-  results$cohortDefinitionId <- bit64::as.integer64(results$cohortDefinitionId)
   expect_equal(results, cohortInclusionRules)
   DatabaseConnector::disconnect(conn)
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ Depends: @@
       R (>= 3.6.0),
       R6
     Imports:
-      bit64,
       checkmate,
       digest,
       dplyr,
@@ Expand Down @@