Fixing R CMD check notes

OHDSI · Jun 12, 2024 · 9300aff · 9300aff
1 parent 90e06dd
commit 9300aff
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -29,7 +29,8 @@ Imports:
   jsonlite,
   ResultModelManager,
   SqlRender (>= 1.11.1),
-  stringi (>= 1.7.6)
+  stringi (>= 1.7.6),
+  zip
 Suggests:
   CirceR (>= 1.1.1),
   Eunomia,

diff --git a/R/CohortCount.R b/R/CohortCount.R
@@ -81,11 +81,13 @@ getCohortCounts <- function(connectionDetails = NULL,
         by = "cohortId",
         all.y = TRUE
       )
-      counts <- transform(
-        counts,
-        cohortEntries = ifelse(is.na(cohortEntries), 0L, cohortEntries),
-        cohortSubjects = ifelse(is.na(cohortSubjects), 0L, cohortSubjects)
-      )
+      with(counts, {
+        transform(
+          counts,
+          cohortEntries = ifelse(is.na(cohortEntries), 0L, cohortEntries),
+          cohortSubjects = ifelse(is.na(cohortSubjects), 0L, cohortSubjects)
+        )
+      })
     }
     if (!is.null(databaseId)) {
       counts$databaseId <- databaseId

diff --git a/R/Export.R b/R/Export.R
@@ -113,7 +113,7 @@ exportCohortStatsTables <- function(connectionDetails,
     cohortDatabaseSchema = cohortDatabaseSchema,
     databaseId = databaseId,
     snakeCaseToCamelCase = snakeCaseToCamelCase,
-    cohortTableName = cohortTableNames
+    cohortTableNames = cohortTableNames
   )
 
   for (i in 1:nrow(tablesToExport)) {