Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow integer for cohortId #166

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

anthonysena
Copy link
Collaborator

Allows for the specification of a cohort definition set & negative control outcome definition set with an integer value for the cohortId column.

Additional changes included in this PR:

  • Removal of the inst/csv/cohortDefinitionSetSpecificationDescription.csv and inst/csv/negativeControlOutcomeCohortSetSpecificationDescription.csv files. These are simply created using the createEmpty*DefinitionSet functions. Data types are handled in the functions where appropriate.
  • Adds internal function assertLargeInteger to check that a cohortId or outcomeConceptId are integer values. Using a function like checkmate::assertIntegerish did not work in the case where a cohortId is a numeric/double with a zero mantissa.
  • Adds test cases to ensure that integer value is allowed for the cohortId column and the assertion of large integers works as intended.

@anthonysena anthonysena linked an issue Jun 17, 2024 that may be closed by this pull request
@anthonysena anthonysena merged commit b088443 into develop Jun 17, 2024
12 checks passed
@anthonysena anthonysena deleted the allow-integer-for-cohort-id branch June 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow integer as cohort ID
1 participant