Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in right join for negate subset operator #168

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix bug in right join for negate subset operator #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2739ac
Fix bug in right join for negate subset operator
anthonysena Jun 19, 2024
d2b8017
Add subset logic checks
anthonysena Jun 19, 2024
afe84f7
Fix R CMD checks
anthonysena Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion inst/sql/sql_server/subsets/CohortSubsetOperator.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ FROM (
HAVING COUNT (DISTINCT S.COHORT_DEFINITION_ID) >= @subset_length
) A
{@negate == '1'}?{
RIGHT JOIN @target_table B ON B.subject_id = A.subject_id
RIGHT JOIN @target_table B ON B.subject_id = A.subject_id
AND b.cohort_start_date = a.cohort_start_date
WHERE A.subject_id IS NULL
}
Loading
Loading